Expose the probe amount range on ProbingConfigBuilder - #1089
Open
joschisan wants to merge 1 commit into
Open
Conversation
The bounds each probe's amount is drawn from were baked-in crate defaults (1k - 10k sats). Nodes that mostly send larger payments want larger probes, since knowing a route passes 10k sats says little about whether it passes 500k - add amount_range_msat to the builder (plus the uniffi Arced variant and UDL) and thread it into both built-in strategies. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013fi458uGXp51nh5wMNhwWY
|
I've assigned @tnull as a reviewer! |
joschisan
marked this pull request as draft
September 5, 2026 08:13
joschisan
marked this pull request as ready for review
September 5, 2026 08:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The amount each probe is drawn from was fixed to the crate defaults of 1k - 10k sats. Nodes that mostly send larger payments want larger probes, since knowing a route passes 10k sats says little about whether it passes 500k. This adds
amount_range_msattoProbingConfigBuilder(andset_amount_range_msaton the uniffi variant) and threads it into both built-in strategies; the defaults are unchanged.I am using this in prod already for a custom fedimint gateway.