Improve logging #108
Merged
Improve logging #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnull
force-pushed
the
2023-05-improve-logging
branch
from
6b772ae to
5181b30
Compare
tnull
force-pushed
the
2023-05-improve-logging
branch
2 times, most recently
from
b022172 to
4266b2f
Compare
tnull
force-pushed
the
2023-05-improve-logging
branch
4 times, most recently
from
af8de05 to
f2d157f
Compare
|
Rebased after #93 has been merged. |
tnull
force-pushed
the
2023-05-improve-logging
branch
from
f2d157f to
d80aceb
Compare
|
Rebased on main after #101 landed. |
tnull
force-pushed
the
2023-05-improve-logging
branch
from
d80aceb to
3d87eae
Compare
|
Rebased on main after #88 landed. |
tnull
force-pushed
the
2023-05-improve-logging
branch
from
3d87eae to
f4d3ca8
Compare
jkczyz
reviewed
Jun 1, 2023
tnull
force-pushed
the
2023-05-improve-logging
branch
from
f4d3ca8 to
31fd0c8
Compare
tnull
force-pushed
the
2023-05-improve-logging
branch
from
31fd0c8 to
7ece643
Compare
Squashed without further changes. |
jkczyz
reviewed
Jun 1, 2023
tnull
force-pushed
the
2023-05-improve-logging
branch
from
7ece643 to
52ccd58
Compare
jkczyz
approved these changes
Jun 1, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #93, Fixes #109.We improve our logging output by logging more detailed errors and introduce logging to
start/stopmethods.Additionally, we expose the log level via
Config::log_levelandBuilder::set_log_level.