-
Notifications
You must be signed in to change notification settings - Fork 506
interactive-tx: Add dual-funding flow, using the interactive tx protocol (feature 28/29) #851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
998b789
spelling: fix spelling mistakes + add new words to ignore spelling
niftynei 7f57338
interactive-tx: Add dual-funding flow, using the interactive tx protocol
niftynei 6ce7491
v2 opens: add a `tx_abort` message
niftynei 11b8451
Clarify RBF funding requirements
t-bast a810c67
Use signed amounts in RBF messages
t-bast 0749591
peer-protocol: send first+second commit point in openchanv2 + accept
niftynei 4caa100
v2 opens: proposal to get rid of the minimum estimated fee
niftynei c2ac8a7
Add `require_confirmed_inputs` TLV
t-bast c5f3c75
Add section about liquidity griefing
t-bast 36c04c8
Store state when sending `commitment_signed`
t-bast c33cdc8
Use bitcoin wire encoding for witnesses
dunxen 9f85945
interactive-tx: highlight MUST of serial_id sorting
niftynei d705522
Bolt 2: Make interactive-tx explicitly use SIGHASH_ALL
ddustin e5b2677
tx-abort: port over meaning of the `data` field from `warning`
niftynei 5edaaa6
tx-complete: clarify that the total input/total output incl funding
niftynei 820852e
nit: verbiage + wording
niftynei e73ce64
tx-signatures: address comments regarding underpyament of fees
niftynei 5185bd0
dual-fund, nit: change wording on common input heuristic
niftynei afc4c72
dual-fund, wording: move sighash_all into existing verbiage
niftynei 024df99
dual-fund, verbiage: clarify situation for closing a underfunded channel
niftynei 27ffef4
dual-fund: add `require_confirmed_inputs` to RBF messages
niftynei File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.