Skip to content

Refactor unfocus/input handling #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Refactor unfocus/input handling #403

wants to merge 2 commits into from

Conversation

wouterlucas
Copy link
Contributor

Changes:

  • Added try/catch if an unfocus fails (for any reason) it would completely hang and components wouldn't get unfocussed anymore
  • Replaced expensive .reverse() with a cheaper while -- loop in unfocus
  • Cached Timeout Computation to avoid overwrites with starved CPUs and racing timeouts
  • Denested code into single layer
  • Replaced focusChain = [] with focusChain = 0 for a micro optimisation
  • Minor optimised property access

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2025

Test Results: ✅ PASSED

Run at: 2025-07-03T13:47:33.944Z

Summary:
passed: 118 failed: 0 of 118 tests

@wouterlucas
Copy link
Contributor Author

Close in favor of #423

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michielvandergeest michielvandergeest Awaiting requested review from michielvandergeest michielvandergeest is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wouterlucas