Skip to content

Feat/rc 3.0 #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 28, 2025
Merged

Feat/rc 3.0 #50

merged 7 commits into from
Jul 28, 2025

Conversation

jfboeve
Copy link
Collaborator

@jfboeve jfboeve commented Feb 20, 2025 •
edited
Loading

Changes:

  • Replaced all effects attributes with new shader attributes
  • Changed Effects page to Shader page
  • Added Custom shader page
  • Added 2 custom shaders for demo purposes

TODO:

  • Update package to latest Blits when released

@jfboeve jfboeve marked this pull request as draft February 20, 2025 09:28
@michielvandergeest michielvandergeest changed the base branch from dev to master February 28, 2025 06:37
@michielvandergeest michielvandergeest changed the base branch from master to dev February 28, 2025 06:37
wouterlucas
wouterlucas reviewed Mar 27, 2025
View reviewed changes
package.json Outdated
@@ -40,6 +40,6 @@
},
"dependencies": {
"@firebolt-js/sdk": "^1.4.1",
"@lightningjs/blits": "^1.20.0"
"@lightningjs/blits": "file:../blits"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woopsie, I'll point it to the related blits branch

@michielvandergeest michielvandergeest changed the base branch from dev to feature/v2 July 28, 2025 08:15
michielvandergeest
michielvandergeest approved these changes Jul 28, 2025
View reviewed changes
Copy link
Contributor

@michielvandergeest michielvandergeest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michielvandergeest michielvandergeest marked this pull request as ready for review July 28, 2025 08:19
@michielvandergeest michielvandergeest merged commit 6a4a0f6 into feature/v2 Jul 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterlucas wouterlucas wouterlucas left review comments

@michielvandergeest michielvandergeest michielvandergeest approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jfboeve @wouterlucas @michielvandergeest