Skip to content

Conversation

johanandren
Copy link
Contributor

No description provided.

@@ -1,4 +1,4 @@
resolvers += "Akka library repository".at("https://repo.akka.io/maven")
resolvers += "Akka repository".at("https://repo.akka.io/maven/github_actions")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's also needed in build.sbt ?

@github-actions github-actions bot added Documentation Improvements or additions to the documentation scala-sdk-protobuf labels Oct 2, 2025
@JustinPihony
Copy link
Contributor

I started to add the global resolver, but maven plugins are checked before settings.xml I think. I'll look into the error further tomorrow - and then finish removing the resolver from all samples if the initial ones pass

@sebastian-alfers
Copy link
Contributor

@JustinPihony I think you also need a <pluginRepository>, like this:

<?xml version="1.0" encoding="UTF-8"?>
<settings xmlns="http://maven.apache.org/SETTINGS/1.2.0">
    <profiles>
        <profile>
            <id>akka-profile</id>
            <activation>
                <activeByDefault>true</activeByDefault>
            </activation>
            <repositories>
                <repository>...</repository>
            </repositories>
            <pluginRepositories>
    	        <pluginRepository>...</pluginRepository>
  	        </pluginRepositories>
        </profile>
    </profiles>
    <activeProfiles>
        <activeProfile>akka-profile</activeProfile>
    </activeProfiles>
</settings>

Both contain the same:

 <id>akka-repository</id>
 <name>Akka repository</name>
 <url>https://repo.akka.io/.../secure</url>

@JustinPihony
Copy link
Contributor

No - my current hindrance is the sbt-test. The issue is that it tries to run things "clean", and feeding in the resolvers is hard because it is a task vs a setting...which sbt doesn't like. I am still trying to make it work. AI isn't of any help either ;p

Copy link
Contributor

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typos?

@JustinPihony
Copy link
Contributor

Tests are now passing, with github actions doing all the work. There is one question about the sbt plugin tests that needs either resolved or turned into a followup issue

@JustinPihony
Copy link
Contributor

I have added a way for scripted to generate the necessary files, but cannot figure out a way to trigger the cleanup task I created. triggeredBy and other options do not work.

Justin Pihony added 2 commits October 8, 2025 15:49
Copy link
Contributor

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

Copy link
Contributor

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I had a few minor comments about the script in akka-samples/helloworld-agent#20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants