-
Notifications
You must be signed in to change notification settings - Fork 39
build: Resolver config for SDK sbt plugins #2364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
project/plugins.sbt
Outdated
@@ -1,4 +1,4 @@ | |||
resolvers += "Akka library repository".at("https://repo.akka.io/maven") | |||
resolvers += "Akka repository".at("https://repo.akka.io/maven/github_actions") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's also needed in build.sbt ?
I started to add the global resolver, but maven plugins are checked before settings.xml I think. I'll look into the error further tomorrow - and then finish removing the resolver from all samples if the initial ones pass |
@JustinPihony I think you also need a
Both contain the same:
|
No - my current hindrance is the sbt-test. The issue is that it tries to run things "clean", and feeding in the resolvers is hard because it is a task vs a setting...which sbt doesn't like. I am still trying to make it work. AI isn't of any help either ;p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typos?
samples/scala-protobuf-valueentity-shopping-cart/project/plugins.sbt
Outdated
Show resolved
Hide resolved
Co-authored-by: Patrik Nordwall <[email protected]>
…ns.sbt Co-authored-by: Patrik Nordwall <[email protected]>
…sdk into wip-plugin-resolver
Tests are now passing, with github actions doing all the work. There is one question about the sbt plugin tests that needs either resolved or turned into a followup issue |
I have added a way for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good
samples/java-protobuf-customer-registry-kafka-quickstart/README.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I had a few minor comments about the script in akka-samples/helloworld-agent#20
No description provided.