feat: animate execution page#701
Conversation
|
Hey! This is your new endpoint: https://c075c283.widget-animateexe.pages.dev |
|
Hey! This is your new endpoint: https://92a25e64.widget-animateexe.pages.dev |
77dcdad to
7c77db2
Compare
|
Hey! This is your new endpoint: https://d64097a4.widget-animateexe.pages.dev |
7c77db2 to
2dd02d4
Compare
|
Hey! This is your new endpoint: https://c1f03285.widget-animateexe.pages.dev |
|
Hey! This is your new endpoint: https://a40669b3.widget-animateexe.pages.dev |
| @@ -0,0 +1,11 @@ | |||
| { | |||
| "version": "0.0.1", | |||
There was a problem hiding this comment.
Do we need to merge this config for Claude?
| @@ -1,10 +1,10 @@ | |||
| import type { RouteExtended } from '@lifi/sdk' | |||
There was a problem hiding this comment.
Same file as on Transaction details? Could we make it reusable, if so?
| "ignoreDependencies": ["@mui/system", "csstype"], | ||
| "workspaces": { | ||
| "packages/widget": { | ||
| "ignore": ["src/components/TransactionStatusCard/index.ts"] |
There was a problem hiding this comment.
Could we drop this index file, from this config and in the directory?
| "release:publish:alpha": "pnpm release:publish:build && pnpm -r publish --access public --no-git-checks --tag alpha && pnpm release:clean", | ||
| "release:publish:beta": "pnpm release:publish:build && pnpm -r publish --access public --no-git-checks --tag beta && pnpm release:clean", | ||
| "release:clean": "pnpm -r --parallel --filter './packages/**' --filter '!*-playground-*' --filter '!*-embedded' exec sh -c \"node ../../scripts/postrelease.js && rm -rf *.md\"", | ||
| "storybook": "pnpm --filter widget-storybook storybook", |
There was a problem hiding this comment.
Do we need to filter it out from the released/published packages as well?
| route: RouteExtended, | ||
| toAddress?: string | ||
| ): ExecutionRow[] { | ||
| const { getTransactionLink } = useExplorer() |
There was a problem hiding this comment.
Could you check how stable this dependency is? Otherwise there is no use from this memoization :)
|
Hey! This is your new endpoint: https://fac35a66.widget-animateexe.pages.dev |
|
Hey! This is your new endpoint: https://9251e4a1.widget-animateexe.pages.dev |
Code Inspection Findings🔴 Must address before merge
🟡 Should fix
🔵 Worth noting
Index-based Full test plan including 19 test cases, automation guide, and exit criteria available on request. |
Which Linear task is linked to this PR?
Why was it implemented this way?
Explain the reasoning behind the implementation. Were there alternative approaches? Why was this solution chosen?
Visual showcase (Screenshots or Videos)
If applicable, attach screenshots, GIFs, or videos to showcase the functionality, UI changes, or bug fixes.
Checklist before requesting a review