Skip to content

feat(@clayui/clay-css): LPD-53627 Add paste 16px icons and generated files #6032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ilzamcmed
Copy link

@ilzamcmed ilzamcmed commented Apr 25, 2025

@pat270
Copy link
Member

pat270 commented Apr 29, 2025

@drakonux can we get these icons vertically aligned relative to the viewbox?

not-aligned

Copy link
Member

@pat270 pat270 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need design to vertically center this

@drakonux
Copy link
Member

drakonux commented May 5, 2025

@diegoalo Could you review this? When we discussed it, it made sense not to align them, but I'm unsure about the real reasons behind this decision.

@diegoalo
Copy link

diegoalo commented May 5, 2025

Hello! @drakonux and @pat270,

When discussing how to center this icon, we made several alternatives to visually see which one was optically centered correctly when put next to a line of text. As can be seen here:

image

The mass on the icon (as we have incremented the density on the top) is better compensated in the icon aligned to the top. This, for example, was also the reasoning behind aligning the paste-word icon the same way, as can be seen here:

image

I hope this helps :)

Best!

@pat270
Copy link
Member

pat270 commented May 6, 2025

@diegoalo The top part of the icons are clipping when rendered in the browser.

clipping

@drakonux
Copy link
Member

drakonux commented May 7, 2025

Could you please elaborate on why this is happening, @pat270? Is it related to the conversion we perform for the sprite?

However, we can center the icons to simplify things, @diegoalo. Do what Patrick says.

We may assess what Patrick is describing in another moment cc\ @marcoscv-work

@diegoalo
Copy link

diegoalo commented May 7, 2025

Hello @drakonux @pat270,

Already attached the vertically centered icons in Jira. You can see it here.

Thanks! 👍

@pat270
Copy link
Member

pat270 commented May 7, 2025

Closing in favor of #6053

@pat270 pat270 closed this May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants