LPD-70790 Implement FDS search and filters management through global state v2 #5213

markocikos · 2025-12-03T12:24:45Z

References

What is the goal of this PR?

With this PR, FDS manages search and filters though global state. This enables JS code from any other parts of the page to interact with it. In PR, we are adding fragment samples that showcase this wiring.

See technical notes inline.

What does it look like?

vokoscreenNG-2025-12-03_12-42-09.mp4

liferay-continuous-integration · 2025-12-03T12:24:52Z

CI is automatically triggering the following test suites:

ci:test:sf

liferay-continuous-integration · 2025-12-03T12:24:54Z

Test suite sf has been triggered on http://test-1-37

gemini-code-assist · 2025-12-03T12:25:32Z

Summary of Changes

Hello @markocikos, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the Frontend Data Set (FDS) component by integrating a global state mechanism for managing its search and filter functionalities. This change enables seamless interaction between the FDS and other parts of the page, such as custom fragments, allowing for more dynamic and interconnected user interfaces. The inclusion of sample fragments provides clear examples of how to leverage this new capability, while underlying utility functions and dependencies have been updated to support the new architecture.

Highlights

Global State Management for FDS: Implemented global state management for Frontend Data Set (FDS) search and filters, allowing external JavaScript code to interact with and modify FDS criteria.
FDS Fragment Samples: Introduced new fragment samples ('Filters FDS Sample' and 'Search FDS Sample') to demonstrate how to wire and interact with the FDS global state.
Refactored isReducedMotion Utility: The isReducedMotion utility has been moved from frontend-js-web to accessibility-settings-state-web for better modularity and dependency management.
New deepClone Utility: A new deepClone utility function has been added to frontend-js-web to facilitate deep copying of objects, including function members by reference.
Playwright Test Updates: Extensive updates to Playwright tests for FDS, including new tests for global state integration with fragments and improved handling of page navigation and state synchronization.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request successfully implements search and filter management through a global state, which is a great improvement for modularity and interactivity. The addition of fragment samples effectively demonstrates the new capability. The refactoring of isReducedMotion and the introduction of deepClone are also valuable changes. I've found a few areas for improvement, mainly related to state management patterns and a potential bug in the deepClone utility. My comments provide suggestions to enhance robustness and simplify the code.

...ps/frontend-js/frontend-js-web/src/main/resources/META-INF/resources/main/utils/deepClone.ts

...end-data-set/frontend-data-set-web/src/main/resources/META-INF/resources/FrontendDataSet.tsx

.../frontend-data-set-sample-web/src/main/resources/META-INF/resources/js/fragments/Filters.tsx

markocikos · 2025-12-03T12:28:21Z

...ccessibility/accessibility-settings-state-web/src/main/resources/META-INF/resources/index.ts

 	Record<KEYS, AccessibilityMenuSetting>
 >('accessibility-menu', {} as any);
+
+export {isReducedMotion} from './isReducedMotion';


Moving isReducedMotion to be able to place deepClone in frontend-js-web. Without the move, there would be a circular dependency between frontend-js-web and frontend-js-state-web, as frontend-js-state-web needs to use deepClone.

liferay-continuous-integration · 2025-12-03T12:29:46Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes

Ran com.liferay.source.formatter at released version 1.0.1554.
*The latest version has not been released.

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 3902d652e9ece189f70ee97f785e6bbe1d3108f9

Sender Branch:

Branch Name: LPD-70790-2
Branch GIT ID: aec2b1827a2d49925405066a7fd8192a415cfcbb

1 out of 1 jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2025-12-03T12:30:05Z

Jenkins Build:test-portal-source-format#14245

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-frontend#5213

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - markocikos > liferay-frontend - PR#5213 - 2025-12-03[04:25:02]

Testray Build ID:381756987

Testray Importer:test-portal-source-format#14245

markocikos · 2025-12-03T12:32:08Z

...end-data-set-sample-web/src/main/resources/META-INF/resources/js/AdvancedPropsTransformer.ts

 	const filtersGroups = [
 		{filters: ['date', 'color'], label: 'Group 1'},
-		{filters: ['invalid', 'size'], label: 'Group 2'},
+		{filters: ['clientExtension', 'invalid', 'size'], label: 'Group 2'},


This is a fix of unrelated bug in master, test failures introduced with #5199. CX was not included in advanced sample.

This unfortunately means that our full CI tests are unreliable 😞

markocikos · 2025-12-03T12:33:05Z

modules/test/playwright/tests/frontend-data-set-web/main/tests/advanced/config_in_url.spec.ts


 	await page.getByRole('button', {name: 'Show Results'}).click();
+
+	await waitForFDS({page});


A bunch of flakiness fixes.

markocikos · 2025-12-03T12:34:25Z

.../frontend-data-set-web/src/main/resources/META-INF/resources/management_bar/ManagementBar.js

 			</div>

-			<ActiveFiltersBar
+			<ResultsBar


Bar contains not only actions, but also search results.

markocikos · 2025-12-03T12:35:40Z

...nd-data-set-web/src/main/resources/META-INF/resources/management_bar/controls/ResultsBar.tsx

 									disabled={disabled}
 									displayType="unstyled"
-									onClick={resetFiltersValue}
+									onClick={onClearResultsBar}


Fixing separation of concerns, like here, was necessary in several places.

markocikos · 2025-12-03T12:38:47Z

...frontend-data-set/frontend-data-set-web/src/main/resources/META-INF/resources/utils/types.ts

+	| IDateFilterState
+	| ISelectionFilterState;
+
+interface IFDSState {


All new interfaces have State keyword. The idea is to separate component interfaces and state value (prop) interfaces, by a convention. We often mix those in code, leading to code that is hard to read, and TS gymnastics.

markocikos · 2025-12-03T12:40:31Z

...ps/frontend-js/frontend-js-web/src/main/resources/META-INF/resources/main/utils/deepClone.ts

+ * @param sourceObj The object to clone.
+ * @returns A deep clone of the object.
+ */
+export default function deepClone(object: any) {


If needed, we can expand this with prevention of circular references. I don't really see the case when it is needed.

markocikos · 2025-12-03T12:43:33Z

...end-data-set/frontend-data-set-web/src/main/resources/META-INF/resources/FrontendDataSet.tsx

+		if (
+			globalFDSStateInitialized ||
+			!filterClientExtensionsLoaded ||
+			!cellClientExtensionsLoaded
+		) {
+			return;
+		}


Don't push initial state updates until CXs are loaded.

markocikos · 2025-12-03T15:45:57Z

ci:test:relevant

liferay-continuous-integration · 2025-12-03T15:46:04Z

Test suite relevant has been triggered on http://test-1-38

markocikos · 2025-12-03T15:47:17Z

ci:test:frontend-data-set

liferay-continuous-integration · 2025-12-03T15:47:24Z

Test suite frontend-data-set has been triggered on http://test-1-35

markocikos · 2025-12-03T15:47:34Z

ci:test:sf

liferay-continuous-integration · 2025-12-03T15:47:41Z

Test suite sf has been triggered on http://test-1-33

… prevents future bugs and keeps TS clean. Original global state value is still key as dependency for `useEffect`s.

liferay-continuous-integration · 2025-12-05T09:04:45Z

❌ ci:test:stable - 6 out of 12 jobs passed

❌ ci:test:relevant - 10 out of 21 jobs passed in 1 hour 44 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 10523f8459d048a14619b81344c75208b37d6815

Upstream Comparison:

Branch GIT ID: f107373318f0a3024a15a3849c857a4d53259545
Jenkins Build URL: EE Development Acceptance (master) - 277 - 2025-11-21[04:37:40]

ci:test:stable - 6 out of 12 jobs PASSED

6 Failed Jobs:

functional-upgrade-tomcat101-postgresql163_stable
js-unit
modules-compile
- modules-compile/0/0
modules-integration-postgresql163_stable
- modules-integration-postgresql163_stable/0/0
playwright-js-tomcat101-postgresql163_stable
- ~~playwright-js-tomcat101-postgresql163_stable/0/0~~
unit_stable
- unit_stable/0/0

6 Successful Jobs:

ci:test:relevant - 10 out of 21 jobs PASSED

11 Failed Jobs:

~~test-portal-acceptance-pullrequest(master)~~
functional-upgrade-tomcat101-postgresql163_stable
js-unit
modules-compile
- modules-compile/0/0
modules-integration-postgresql163
- modules-integration-postgresql163/0/0
modules-integration-postgresql163_stable
- modules-integration-postgresql163_stable/0/0
modules-semantic-versioning
- modules-semantic-versioning/0/0
modules-unit
- ~~modules-unit/0/0~~
playwright-js-tomcat101-mysql84
playwright-js-tomcat101-postgresql163
- playwright-js-tomcat101-postgresql163/0/0
playwright-js-tomcat101-postgresql163_stable
- ~~playwright-js-tomcat101-postgresql163_stable/0/0~~
unit_stable
- unit_stable/0/0

10 Successful Jobs:

For more details click here.

Failures unique to this pull:

functional-upgrade-tomcat101-postgresql163_stable/0/3

[beanshell] Executing commands: git clean -dfx
[beanshell] 
[beanshell] commit 3bf0e6559b8a1ea85c1caf5b8a2bf97c221214b3
[beanshell] Author: Lawrence Lee <[email protected]>
[beanshell] Date:   Wed Jul 18 11:36:51 2018 -0500
[beanshell] 
[beanshell]     Fix portlet test to match className
[beanshell] 
[beanshell] Executing commands: git branch | grep \*
[beanshell] Executing commands: git for-each-ref refs/heads --format="%(refname)"
[beanshell] Executing commands: git branch | grep \*
[beanshell] Executing commands: git clean -dfx
[beanshell] Executing commands: git clean -dfx
[beanshell] Executing commands: git log -n 1
[beanshell] Executing commands: git for-each-ref refs/heads --format="%(refname)"
[beanshell] 
[beanshell] commit 34b86ec50cedba4082671f7b14652afca36b49f1
[beanshell] Author: Liferay Continuous Integration <[email protected]>
[beanshell] Date:   Thu Dec 4 02:41:26 2025 -0800
[beanshell] 
[beanshell]     Commit cache
[beanshell] 
[beanshell] Executing commands: git log -n 1
[beanshell] 
[beanshell] commit eef8f68f6d4cb9607a6c7047ec3eae8eaebc2363
[beanshell] Author: Liferay Continuous Integration <[email protected]>
[beanshell] Date:   Tue Dec 2 18:47:20 2025 -0800
[beanshell] 
[beanshell]     subrepo:ignore Update 'modules/dxp/apps/osb/osb-asah/.gitrepo'.
[beanshell] 
[beanshell] Executing commands: git branch | grep \*
[beanshell] Executing commands: git branch | grep \*
[beanshell] Executing commands: git for-each-ref refs/heads --format="%(refname)"
[beanshell] Executing commands: git for-each-ref refs/heads --format="%(refname)"
[beanshell] Executing commands: git log -n 1
[beanshell] Executing commands: git log -n 1
[beanshell] 
[beanshell] commit 3274ff03d23ada9bded2d522bbdc6cfedad1358f
[beanshell] Author: shuyangzhou <[email protected]>
[beanshell] Date:   Tue Dec 2 11:54:54 2025 -0800
[beanshell] 
[beanshell]     LPD-73164 Apply index cache to DLFileEntryImpl
[beanshell] 
[beanshell] 
[beanshell] commit 3274ff03d23ada9bded2d522bbdc6cfedad1358f
[beanshell] Author: shuyangzhou <[email protected]>
[beanshell] Date:   Tue Dec 2 11:54:54 2025 -0800
[beanshell] 
[beanshell]     LPD-73164 Apply index cache to DLFileEntryImpl
[beanshell] 
[beanshell] ParallelExecutor 1 - tearDown completed 15 tasks in 3 seconds averaging 2 seconds per task. 
[stopwatch] [stop.current.job: 9.179 sec]
BUILD SUCCESSFUL

Total time: 12 seconds

echo 'Exit shell.'

Exit shell.

Finished: FAILURE

LocalFile.PortalSmokeUpgrade#ViewPortalSmokeArchiveAndValidateSchema7310 - Console Output - Failed 0 of last 19 - Liferay Log

modules-unit/0/0

[beanshell]

[beanshell] Executing commands: git branch | grep *

[beanshell] Executing commands: git log -n 1

[beanshell] Executing commands: git for-each-ref refs/heads --format="%(refname)"

[beanshell] Executing commands: git branch | grep *

[beanshell]

[beanshell] commit 1e7091413da9107d559bb569ad2b5f8cbfd312d1

[beanshell] Author: Brian Chan <[email protected]>

[beanshell] Date:   Tue Dec 2 18:11:06 2025 -0800

[beanshell]

[beanshell]     LPD-73038 SF

[beanshell]

[beanshell] Executing commands: git clean -dfx

[beanshell] Executing commands: git log -n 1

[beanshell] Executing commands: git for-each-ref refs/heads --format="%(refname)"

[beanshell] Executing commands: git clean -dfx

[beanshell]

[beanshell] commit 34b86ec50cedba4082671f7b14652afca36b49f1

[beanshell] Author: Liferay Continuous Integration <[email protected]>

[beanshell] Date:   Thu Dec 4 02:41:26 2025 -0800

[beanshell]

[beanshell]     Commit cache

[beanshell]

[beanshell] Executing commands: git log -n 1

[beanshell]

[beanshell] commit 6aa4f9d65d9552cc491ef8d0300ef8dd057c7713

[beanshell] Author: Brian Chan <[email protected]>

[beanshell] Date:   Wed Dec 3 09:42:28 2025 -0800

[beanshell]

[beanshell]     LPD-70122 prep next

[beanshell]

[beanshell] Executing commands: git branch | grep *

[beanshell] Executing commands: git branch | grep *

[beanshell] Executing commands: git for-each-ref refs/heads --format="%(refname)"

[beanshell] Executing commands: git for-each-ref refs/heads --format="%(refname)"

[beanshell] Executing commands: git log -n 1

[beanshell] Executing commands: git log -n 1

[beanshell]

[beanshell] commit 5bfea19a9d027b49bbf3276990259e1e01629b36

[beanshell] Author: Marcela Cunha <[email protected]>

[beanshell] Date:   Thu Dec 4 15:37:59 2025 -0300

[beanshell]

[beanshell]     LPD-43541 There is no EnableLocalization after FF LPD-32050 removal

[beanshell]

[beanshell]

[beanshell] commit 5bfea19a9d027b49bbf3276990259e1e01629b36

[beanshell] Author: Marcela Cunha <[email protected]>

[beanshell] Date:   Thu Dec 4 15:37:59 2025 -0300

[beanshell]

[beanshell]     LPD-43541 There is no EnableLocalization after FF LPD-32050 removal

[beanshell]

[beanshell] ParallelExecutor 1 - tearDown completed 15 tasks in 3 seconds averaging 2 seconds per task.

[stopwatch] [stop.current.job: 7.562 sec]

BUILD SUCCESSFUL
Total time: 9 seconds

echo 'Exit shell.'
Exit shell.
Finished: FAILURE
functional-upgrade-tomcat101-postgresql163_stable/0/1
1. LocalFile.PortalSmokeAutoUpgrade#ViewPortalSmokeArchiveAutoUpgrade7310 - Poshi Report - Poshi Summary - Console Output - Failed 2 of last 21 - Liferay Log
functional-upgrade-tomcat101-postgresql163_stable/0/2
1. LocalFile.PortalSmokeAutoUpgrade#ViewPortalSmokeArchiveAutoUpgrade7413 - Poshi Report - Poshi Summary - Console Output - Failed 2 of last 21 - Liferay Log
functional-upgrade-tomcat101-postgresql163_stable/0/4
1. LocalFile.PortalSmokeUpgrade#ViewPortalSmokeArchiveAndValidateSchema7413 - Poshi Report - Poshi Summary - Console Output - Failed 0 of last 19 - Liferay Log
...

For upstream results, click here.

Test bundle downloads:

liferay-portal-bundle-tomcat.tar.gz

liferay-continuous-integration · 2025-12-05T09:06:28Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#24874

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-frontend#5213

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - markocikos > liferay-frontend - PR#5213 - 2025-12-04[23:20:20]

Testray Build ID:383689076

Testray Importer:test-portal-acceptance-pullrequest(master)#24874

markocikos · 2025-12-05T09:59:55Z

ci:test:stable

liferay-continuous-integration · 2025-12-05T10:00:06Z

Test suite stable has been triggered on http://test-1-37

liferay-continuous-integration · 2025-12-05T11:11:38Z

❌ ci:test:stable - 25 out of 33 jobs passed in 1 hour 11 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: ffb154d7f2fd1d9740ece84e9aac5863c9e50cee

ci:test:stable - 25 out of 33 jobs PASSED

8 Failed Jobs:

~~test-portal-acceptance-pullrequest(master)~~
build-iw
- build-iw/0/0
functional-upgrade-tomcat101-postgresql163_stable
js-unit
modules-compile
modules-integration-postgresql163_stable
- modules-integration-postgresql163_stable/0/0
modules-unit_stable
- modules-unit_stable/0/0
playwright-compile
- playwright-compile/0/0
playwright-js-smoke-tomcat101-hypersonic20
- ~~playwright-js-smoke-tomcat101-hypersonic20/0/0~~
playwright-js-tomcat101-postgresql163_stable
- ~~playwright-js-tomcat101-postgresql163_stable/0/0~~
rest-builder
- rest-builder/0/0
service-builder
- service-builder/0/0
- service-builder/0/1
unit_stable
- unit_stable/0/0

25 Successful Jobs:

For more details click here.

Failures unique to this pull:

For upstream results, click here.

Test bundle downloads:

liferay-portal-bundle-tomcat.tar.gz

liferay-continuous-integration · 2025-12-05T11:12:58Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#24877

Jenkins Report:jenkins-report.html

Jenkins Suite:stable

Pull Request:liferay-frontend#5213

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:stable - markocikos > liferay-frontend - PR#5213 - 2025-12-05[02:00:15]

Testray Build ID:383769586

Testray Importer:test-portal-acceptance-pullrequest(master)#24877

…all CI failures

markocikos · 2025-12-05T13:58:16Z

ci:test:relevant

liferay-continuous-integration · 2025-12-05T13:58:23Z

Test suite relevant has been triggered on http://test-1-39

liferay-continuous-integration · 2025-12-05T16:02:23Z

❌ ci:test:stable - 7 out of 12 jobs passed

❌ ci:test:relevant - 12 out of 22 jobs passed in 2 hours 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 098e3f6b6ac8fe2118aea5b168764437f132a628

Upstream Comparison:

Branch GIT ID: feff86712bf0eeba59f68873f5bd0eb989a50337
Jenkins Build URL: EE Development Acceptance (master) - 282 - 2025-11-24[12:39:40]

ci:test:stable - 7 out of 12 jobs PASSED

5 Failed Jobs:

functional-upgrade-tomcat101-postgresql163_stable
js-unit
modules-compile
- modules-compile/0/0
modules-integration-postgresql163_stable
- modules-integration-postgresql163_stable/0/0
playwright-js-tomcat101-postgresql163_stable
- ~~playwright-js-tomcat101-postgresql163_stable/0/0~~
unit_stable
- unit_stable/0/0

7 Successful Jobs:

ci:test:relevant - 12 out of 22 jobs PASSED

10 Failed Jobs:

~~test-portal-acceptance-pullrequest(master)~~
functional-upgrade-tomcat101-postgresql163_stable
js-unit
modules-compile
- modules-compile/0/0
modules-integration-postgresql163
- modules-integration-postgresql163/0/0
modules-integration-postgresql163_stable
- modules-integration-postgresql163_stable/0/0
modules-semantic-versioning
- modules-semantic-versioning/0/0
modules-unit
- modules-unit/0/0
playwright-js-tomcat101-mysql84
playwright-js-tomcat101-postgresql163
- playwright-js-tomcat101-postgresql163/0/0
playwright-js-tomcat101-postgresql163_stable
- ~~playwright-js-tomcat101-postgresql163_stable/0/0~~
unit_stable
- unit_stable/0/0

12 Successful Jobs:

For more details click here.

Failures unique to this pull:

For upstream results, click here.

Test bundle downloads:

liferay-portal-bundle-tomcat.tar.gz

liferay-continuous-integration · 2025-12-05T16:04:02Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#15365

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-frontend#5213

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - markocikos > liferay-frontend - PR#5213 - 2025-12-05[05:58:28]

Testray Build ID:383899289

Testray Importer:test-portal-acceptance-pullrequest(master)#15365

markocikos requested review from dsanz and juanjofgliferay December 3, 2025 12:24

markocikos self-assigned this Dec 3, 2025

markocikos requested a review from liferay-frontend as a code owner December 3, 2025 12:24

markocikos mentioned this pull request Dec 3, 2025

LPD-70790 Implement FDS search management through global state #5187

Closed

liferay-continuous-integration added the ci:test:sf - pending label Dec 3, 2025

gemini-code-assist bot reviewed Dec 3, 2025

View reviewed changes

markocikos commented Dec 3, 2025

View reviewed changes

liferay-continuous-integration added ci:test:sf - success and removed ci:test:sf - pending labels Dec 3, 2025

markocikos commented Dec 3, 2025

View reviewed changes

liferay-continuous-integration added ci:test:sf - pending and removed ci:test:sf - success labels Dec 3, 2025

markocikos added 2 commits December 5, 2025 08:25

LPD-70790 Simplify

3ddbce4

LPD-70790 Consistently unfreeze before using global state value. This…

002b7cd

… prevents future bugs and keeps TS clean. Original global state value is still key as dependency for `useEffect`s.

liferay-continuous-integration added ci:test:relevant - failure ci:test:stable - failure and removed ci:test:relevant - pending ci:test:stable - pending labels Dec 5, 2025

liferay-continuous-integration added ci:test:stable - pending ci:test:stable - failure and removed ci:test:stable - failure ci:test:stable - pending labels Dec 5, 2025

TEMPORARY - mark tests for migration to PW, to check if this causing …

ea2a0b5

…all CI failures

markocikos force-pushed the LPD-70790-2 branch from b3326ba to ea2a0b5 Compare December 5, 2025 13:58

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:relevant - failure ci:test:stable - failure and removed ci:test:relevant - failure ci:test:stable - failure ci:test:relevant - pending ci:test:stable - pending labels Dec 5, 2025


		await page.getByRole('button', {name: 'Show Results'}).click();

		await waitForFDS({page});

LPD-70790 Implement FDS search and filters management through global state v2 #5213

Are you sure you want to change the base?

LPD-70790 Implement FDS search and filters management through global state v2 #5213

Uh oh!

Conversation

markocikos commented Dec 3, 2025

References

What is the goal of this PR?

What does it look like?

Uh oh!

liferay-continuous-integration commented Dec 3, 2025

Uh oh!

liferay-continuous-integration commented Dec 3, 2025

Uh oh!

gemini-code-assist bot commented Dec 3, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

liferay-continuous-integration commented Dec 3, 2025

✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes

Base Branch:

Sender Branch:

For more details click here.

Uh oh!

liferay-continuous-integration commented Dec 3, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

markocikos commented Dec 3, 2025

Uh oh!

liferay-continuous-integration commented Dec 3, 2025

Uh oh!

markocikos commented Dec 3, 2025

Uh oh!

liferay-continuous-integration commented Dec 3, 2025

Uh oh!

markocikos commented Dec 3, 2025

Uh oh!

liferay-continuous-integration commented Dec 3, 2025

Uh oh!

liferay-continuous-integration commented Dec 5, 2025

❌ ci:test:stable - 6 out of 12 jobs passed

❌ ci:test:relevant - 10 out of 21 jobs passed in 1 hour 44 minutes

Base Branch:

Upstream Comparison:

6 Failed Jobs:

11 Failed Jobs:

For more details click here.

Failures unique to this pull:

For upstream results, click here.

Test bundle downloads:

Uh oh!

liferay-continuous-integration commented Dec 5, 2025

Uh oh!

markocikos commented Dec 5, 2025

Uh oh!

liferay-continuous-integration commented Dec 5, 2025