Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build <VideoPlayer /> Component #18

Open
michael-martin-al opened this issue Apr 6, 2018 · 8 comments
Open

Build <VideoPlayer /> Component #18

michael-martin-al opened this issue Apr 6, 2018 · 8 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@michael-martin-al
Copy link

Summary

Build a component for displaying and playing a single video. Your job is to create a very similar user interface using only components from our melos component library: https://github.com/lifechurch/melos

You won't be able to recreate the exact look and feel that you see on the Bible.com videos page, but that's OK! 😄 What you see on Bible.com represents our old design style, but melos represents our newest design specs. I am sure you'll have questions, so feel free to ping me. We'll get one of our YouVersion designers to give you the final 👍 when you're done. So, you can expect there to be some back and forth work with them getting it just right.

Mock API Data

After #11 has been completed, there should be some mock data available to use while building your component. Instead of hard-coding the strings and images, you want to grab those from the mock api data. If you have questions about this, just make a comment here and we'll do our best to answer quickly.

This is what you're building

While Playing

image

Before It Plays

image

On Hover, Before Play

image

@michael-martin-al michael-martin-al added enhancement New feature or request help wanted Extra attention is needed labels Apr 6, 2018
@rnice01
Copy link
Contributor

rnice01 commented Apr 8, 2018

I'd like to work on this one!

@michael-martin-al
Copy link
Author

Thanks Rob. Hoping to stick with the HTML5 player for this. I don't think I mentioned it. Hopefully, we won't need any third-party players or plugins. We were able to do that for our Audio player. But, I haven't done much research for the video player yet. Let me know if you have questions.

@rnice01
Copy link
Contributor

rnice01 commented Apr 8, 2018

Sounds good, thanks!

@michael-martin-al
Copy link
Author

@rnice01 how are things going on this? Obviously, this whole Videos feature is useless if the videos can't be played. So, the work you're doing is HUGELY important. Let me know if you have questions or need clarification on anything.

@rnice01
Copy link
Contributor

rnice01 commented Apr 16, 2018

@michael-martin-al
Let me wrap up I have tonight and I’ll put in my PR for review. Sorry for the slow progress things have gotten busy at home.

@michael-martin-al
Copy link
Author

No worries @rnice01. I'm not worried about speed right now. I just want to be sure you have what you need.

@michael-martin-al
Copy link
Author

@rnice01 did you submit a PR for this already? I cannot find it.

@srsheldon
Copy link

@michael-martin-al, I know this is super late in the game but is this still an ask? I recently joined the youversion-vol-devs group and the project they had available was completed so I was just looking for other ways to help. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants