-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish building out <Video /> Component #19
Comments
I'm working on this at the moment! Could you give me some guidance on how to improve on what I have in my branch so far: https://github.com/wagicalgale/youversion-web-open-ideas/tree/add-videos-page Thanks :) |
It's difficult to say for sure without seeing the code in action, but it looks like you're headed in the right direction. Once you submit a PR, it will automatically deploy your version of the app so I can see it. Feel free to submit a PR just for the sake of starting this review, even if you're not 💯complete yet. |
@WagicalGale , in case you're interested, I have the instructions for deploying a fork to Netlify for demo purposes. I just submitted the PR, but in the interim you can access them here https://github.com/glasssd/youversion-web-open-ideas/blob/master/README-DEPLOY.md if that would help. |
@glasssd that's great, thanks for putting the work into that 👍 |
Build out videos object #19
Summary
Finish building out the
<Video />
component for displaying all the details of a single video (the component is being built in #18 ). Your job is to create a very similar user interface as https://www.bible.com/videos/269-why-have-you-forsaken-me-from-lightworkers-media using only components from ourmelos
component library: https://github.com/lifechurch/melos . If you start working on this issue before #18 is complete, feel free to put an empty placeholder component in place.You won't be able to recreate the exact look and feel that you see on the Bible.com videos page, but that's OK! 😄 What you see on Bible.com represents our old design style, but
melos
represents our newest design specs. I am sure you'll have questions, so feel free to ping me. We'll get one of our YouVersion designers to give you the final 👍 when you're done. So, you can expect there to be some back and forth work with them getting it just right.Mock API Data
After #11 has been completed, there should be some mock data available to use while building your component. Instead of hard-coding the strings and images, you want to grab those from the mock api data. If you have questions about this, just make a comment here and we'll do our best to answer quickly.
This is What You're Building
The text was updated successfully, but these errors were encountered: