Merge pull request #22 from life4/no-global-rand-seed

Don't use global rand.Seed
life4 · Aug 24, 2023 · 14c724f · 14c724f
2 parents 3a75f8c + 897d6cc
commit 14c724f
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/slices/slice.go b/slices/slice.go
@@ -21,8 +21,8 @@ func Choice[S ~[]T, T any](items S, seed int64) (T, error) {
 	if seed == 0 {
 		seed = time.Now().UnixNano()
 	}
-	rand.Seed(seed)
-	i := rand.Intn(len(items))
+	r := rand.New(rand.NewSource(seed))
+	i := r.Intn(len(items))
 	return items[i], nil
 }
 
@@ -448,11 +448,11 @@ func Shuffle[S ~[]T, T any](items S, seed int64) {
 	if seed == 0 {
 		seed = time.Now().UnixNano()
 	}
-	rand.Seed(seed)
+	r := rand.New(rand.NewSource(seed))
 	swap := func(i, j int) {
 		items[i], items[j] = items[j], items[i]
 	}
-	rand.Shuffle(len(items), swap)
+	r.Shuffle(len(items), swap)
 }
 
 // Sort returns sorted slice
@@ -548,11 +548,11 @@ func TakeRandom[S ~[]T, T any](items S, count int, seed int64) (S, error) {
 	if seed == 0 {
 		seed = time.Now().UnixNano()
 	}
-	rand.Seed(seed)
+	r := rand.New(rand.NewSource(seed))
 	swap := func(i, j int) {
 		items[i], items[j] = items[j], items[i]
 	}
-	rand.Shuffle(len(items), swap)
+	r.Shuffle(len(items), swap)
 	return items[:count], nil
 }