feat: strict interface-contract matching for TW upgrade #1239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hardhat Unit Tests Coverage SummaryDiff against masterResults for commit: c841cdc Minimum allowed coverage is ♻️ This comment has been updated with latest results |
F4ever
previously approved these changes
Jul 14, 2025
tamtamchik
requested changes
Jul 15, 2025
package.json
Outdated
| "test:integration:fork:mainnet:custom": "MODE=forking hardhat test --network mainnet-fork", | ||
| "typecheck": "tsc --noEmit", | ||
| "prepare": "husky", | ||
| "check:interfaces": "bash -c 'forge inspect contracts/common/interfaces/IStakingModule.sol abi | diff -u - <(forge inspect contracts/0.4.24/interfaces/IStakingModule.sol abi)'", |
There was a problem hiding this comment.
Can we move this to hardhat tasks overrides maybe?
| import {IStakingRouter} from "contracts/common/interfaces/IStakingRouter.sol"; | ||
|
|
||
| contract StakingRouter_Mock is IStakingRouter { | ||
| contract StakingRouter_Mock { |
There was a problem hiding this comment.
Should implement interface here.
| import {IStakingRouter} from "contracts/common/interfaces/IStakingRouter.sol"; | ||
|
|
||
| contract StakingRouter_Mock is IStakingRouter { | ||
| contract StakingRouter_Mock { |
There was a problem hiding this comment.
Suggested change
| contract StakingRouter_Mock { | |
| contract StakingRouter__Mock { |
| import {IStakingRouter} from "contracts/0.8.9/oracle/AccountingOracle.sol"; | ||
|
|
||
| contract StakingRouter__MockForAccountingOracle is IStakingRouter { | ||
| contract StakingRouter__MockForAccountingOracle { |
| import {StakingRouter} from "contracts/0.8.9/StakingRouter.sol"; | ||
|
|
||
| contract StakingRouter__MockForDepositSecurityModule is IStakingRouter { | ||
| contract StakingRouter__MockForDepositSecurityModule { |
There was a problem hiding this comment.
Looks like we do not need this, can be changed to ABI comparacent
|
Current output: |
TheDZhon
reviewed
Jul 16, 2025
| }, | ||
| { | ||
| commonInterfaceFqn: "contracts/common/interfaces/IValidatorsExitBusOracle.sol:IValidatorsExitBusOracle", | ||
| additionalInterfaces: ["contracts/0.8.9/oracle/ValidatorsExitBus.sol:ValidatorsExitBus"], |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only for the contracts updated/deployed on Triggerable Withdrawals upgrade.