Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cyclone: use HAVE_ARMv6 flag for backward asm compatibility #1922

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Apaczer
Copy link

@Apaczer Apaczer commented Jan 23, 2025

after 5f98dc3 the build fails for old armv5 platform when using CYCLONE, so for compatibility use HAVE_ARMv6 in preprocessed cyclone.S (e.g. use in upstream)

@grant2258
Copy link
Contributor

grant2258 commented Jan 23, 2025

You essentially changing all platforms that dont need this update to be slower. Im not going to be looking over this stuff after adding it and getting it working. Make sure your using the cyclone from https://github.com/notaz/cyclone68000 and not something older as the source for the 68k if your wanting these changes. Im sure someone will come along and say hey this isint ideal for pi2 pi3 pi4 and mini classics. Since im not using it anyway im not too bothered.

It would be better including generating the code in the makefile and only add the HAVE_ARMv6 to the platforms that needs it. Im not sure why you added these entries to the makefile as they only apply to compiling the code generation program.

I can see you hand edited the file the only problem is you will need to update it again if the code gets generated again. If you can live with that is shouldn't be an issue at all. The only platform that uses this is the vita atm anyway unless a USE_CYCLONE is defined when compiling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants