tests: fixed init/dt regressions and add os.exit() if UNATTENDED=1 #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- load() function was not being called due to some merge error conflict that added an extra "end" in the wrong place - the `dt` value was not passed into `update(dt)` due to a difference in how `xpcall()` works between lua 5.1 and 5.2 - switched syntax from `state.['member']` to `state.member` for readability - Fixes inconsistent background color by setting the background color ever frame instead of just once on Load()
This should be some handy boilerplate to facilitate running tests as part of PR smoke checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dtvalue was not passed intoupdate(dt)due to a difference in howxpcall()works between lua 5.1 and 5.2state.['member']tostate.memberfor readabilitycalling os.exit() if UNATTENDED=1 (env)
This should be some handy boilerplate to facilitate running tests as part of PR smoke checks. It's also useful for my local bash shell driven development testing too, but I'm hesitant to make it the default behavior, since I can imagine other workflows that might use a persistent instance of retroarch to relaunch the test repeatedly after lua modifications.
Getting pretty close to the point where the unit tests - or some significant subset of them - should be runnable via the CI to improve PR test coverage. (still some blockers such as having a libretro frontend that can run in a way that is friendly to the restrictions imposed by github runners, eg. no GPU)