make: fix PhysFS defines to match expected assignment of [0,1] #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a codebase uses `#if HAVE_FOOBAR` it is necessary to use `HAVE_FOOBAR=1` to ensure the compiler actually enables the codeblock in the expected way. When the code uses `#ifdef HAVE_FOOBAR` then a define without any assignment is sufficient to enable the feature. In general the `#if` form should be preferred over the `#ifdef` form for reasons of explicitness, along with a few other minor benefits related to inheriting or overriding the set value later on in the build system or at the source code level. PhysFs uses/expects this form, but lutro generally does not (yet).
…m the CLI ... the power of `?=` unleashed.
RobLoach
approved these changes
Jan 26, 2025
There was a problem hiding this comment.
I'm not sure how extensive the PhysFS usage in Lutro is, but I have pushed up libretro support for PhysFS that makes PhysFS use the libretro virtual file system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a codebase uses
#if HAVE_FOOBARit is necessary to useHAVE_FOOBAR=1to ensure the compiler actually enables the codeblock in the expected way. When the code uses#ifdef HAVE_FOOBARthen a define without any assignment is sufficient to enable the feature.The
#ifis recommended over the#ifdefform for reasons of explicitness, along with a few other minor benefits related to inheriting or overriding the set value later on in the build system or at the source code level. PhysFs uses/expects this form, but lutro generally does not (yet).