featureflags: fix a bug which caused all flags to report as 'false' #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds the featureflag unit test, which was missing from my previous PR (forgot to add). - Adds a set of special internal values to help verify the behavior of the three possible valid macro states. - Also clarifies the use of "feature flags" as the term for this new table, both in function name and comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the featureflag unit test, which was missing from my previous PR (forgot to add).
Also clarifies the use of "feature flags" as the term for this new table, both in function name and comments.
This bug slipped in as a result (as usual) of some late-stage cleanup and refactor that I did just before commit. As a result, I went ahead and implemented a unit test of sorts that I had kind of thought about implementing earlier but, due to time constraints, I opted to skip past.
An _score naming convention is used to differentiate the internal values for unit testing from the regular values.