getWorkingDirectory: implemented to return "./" #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstine35
force-pushed
the
getUserDirectory
branch
from
ca154c2 to
04ead8a
Compare
kivutar
approved these changes
Jan 23, 2025
RobLoach
approved these changes
Jan 24, 2025
| */ | ||
| int fs_getWorkingDirectory(lua_State *L) | ||
| { | ||
| lua_pushstring(L, "./"); |
There was a problem hiding this comment.
This makes sense to me! While Working directory isn't really a thing in libretro, I think this is a worthy workaround.
|
Looks like a small conflict, but good! |
It's enough to allow most things that might want to use it to work. The function should only be used for local development or debugging purposes anyway, as the concept of CWD is not portable and is not friendly to end users running program via high-level shells (eg. Windows Explorer or Finder or such).
jstine35
force-pushed
the
getUserDirectory
branch
from
04ead8a to
28a0a1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's enough to allow most things that might want to use it to work. The function should only be used for local development or debugging purposes anyway, as the concept of CWD is not portable and is not friendly to end users running program via high-level shells (eg. Windows Explorer or Finder or such).
Difference from LOVE: LOVE returns the CWD as an absolute path. Lutro returns a relative path.
I split it out from PR #260 since the latest implementation of
getUserDirectorywill no longer usegetCurrentDirectoryas a fallback. I felt it was still worthwhile to retain the work of implementinggetCurrentDirectory()even if it's not directly supported by libretro API, and not recommended to use it anywhere outside of local/development contexts. I think it is still nice to have these sort of dev-friendly APIs available for use, and assume devs will use them effectively and responsibly.