Disable buffering on stdout by default. #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change imposes a default behavior that ensures stdout prints in realtime and is in correct chronological sequence with stderr. It is the generally expected behavior for any multimedia or gaming application. If a specialized script (for unit testing?) intends only to output large sets of results to stdout, it can optionally re-enabe this buffering within that script to gain a tiny amount of execution speed.
I had added code to tests/audio to turn this on manually, and was about to do the same thing to the other test, when I realized it is better done by default for all game apps. There is no tangible benefit to buffered stdout for games, and tons of drawbacks.