Add CoreLocation location driver for macOS and iOS #17591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This one is just for fun, because Android had it, but there's no core for iOS at the moment to test this with.
Hopefull this encourages more core support!
I haven't been able to test on macOS either but it should theoretically be the same code and APIs.
I got the driver to initialize and it initiated the request for location permissions.
Don't forget to add entitlements and
Info.plistentries for CoreLocation and to link CoreLocation.framework!To incorporate into build add
HAVE_CORELOCATIONto the.xcconfig.Related Issues
None found.
Related Pull Requests
None found.
Reviewers
[If possible @mention all the people that should review your pull request]