for iOS: apply revision to default app icon file in selectable icons catalog #17582
+0
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenjamescox
changed the title
stevenjamescox
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update PNG in Default.appiconset in Icons.xcassets with subtle drag shadow.
This default app icon's variously-sized PNG files were updated in Media.xcassets in #17574.
However, given the implementation of user-selectable app icons (#16020), the PNG in Default.appiconset in Icons.xcassets should also have been updated. My bad!
Sample
Before & After image files (their corners are automatically rounded in actual use):
