Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed warning + allow cli arguments on Haiku #16887

Merged
merged 1 commit into from
Aug 17, 2024

Conversation

kwyxz
Copy link
Contributor

@kwyxz kwyxz commented Aug 17, 2024

Description

Since RA was ported to Haiku, command-line arguments have been broken and I never took the time to investigate this. It turns out this snippet is the problem:

   if (info->environ_get)
      info->environ_get(rarch_argc_ptr,
            rarch_argv_ptr, info->args, wrap_args);

This goes beyond my abilities and just skipping this piece of code (on Haiku that is) solves the immediate issue. Of course if anybody more skilled feels like taking a shot at it, it'll be more then appreciated. The objective is to allow ES-DE to start RA with the appropriate core, now that ES-DE was ported to Haiku.

Also I accidentally caused a new warning in #16881 so the small fix to retroarch.c resolves this.

Related Pull Requests

#16881 caused this warning :

CC retroarch.c
retroarch.c: In function ‘command_event’:
retroarch.c:3095:4: warning: enumeration value ‘CMD_EVENT_ADD_TO_PLAYLIST’ not handled in switch [-Wswitch]
 3095 |    switch (cmd)
      |    ^~~~~~

@LibretroAdmin LibretroAdmin merged commit fab8619 into libretro:master Aug 17, 2024
27 checks passed
Sunderland93 pushed a commit to Sunderland93/RetroArch that referenced this pull request Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants