Skip to content
This repository was archived by the owner on Feb 3, 2025. It is now read-only.

fix(Structures): GuildIntegration missing optional #39

Open
wants to merge 2 commits into
base: beta
Choose a base branch
from

Conversation

SiroTM
Copy link
Collaborator

@SiroTM SiroTM commented Jun 9, 2021

This PR makes the following properties optional: enable_emoticons, expire_behavior, revoked, role_id, subscriber_count, syncing and user.
This also renames IntegrationExpireBehaviour to IntegrationExpireBehavior .

SiroTM added 2 commits June 9, 2021 09:58

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Member

@bsian03 bsian03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather keeping the types as they are but default export a union of GuildIntegration and BotIntegration in this case

@Khaaz
Copy link
Collaborator

Khaaz commented Jun 12, 2021

lol uk vs us naming.
I agree with accepting both names potentially.
Otherwise we just need to choose one and be consistent about it

@Khaaz Khaaz changed the title refactor(Structures): GuildIntegration fix(Structures): GuildIntegration missing optional Jun 12, 2021
@Khaaz Khaaz added repo: structures semver: patch t: documentation Improvements or additions to documentation t: fix Something isn't working labels Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
repo: structures semver: patch t: documentation Improvements or additions to documentation t: fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants