Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: UI fixes, persist messages, set up cxn limit #39

Merged
merged 17 commits into from
Apr 14, 2023
Merged

feat: UI fixes, persist messages, set up cxn limit #39

merged 17 commits into from
Apr 14, 2023

Conversation

maschad
Copy link
Member

@maschad maschad commented Apr 12, 2023 •
edited
Loading

This PR addresses a few things:

  • remove Peer ID to connect to and multiaddr to connect to
  • persist chat messages on chat tab (when switching between chat tab and connecting to peer tab, the chat messages are lost)
  • set up max connection limit in js-libp2p-gossipsub (limit the size of meshes)
  • Refactor UI including Icons and burger button

image

image

Related #35

@vercel
Copy link

vercel bot commented Apr 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
universal-connectivity ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2023 4:57am

@p-shahi p-shahi mentioned this pull request Apr 12, 2023
Closed
21 tasks
@maschad maschad changed the title UI Updates Remaining fixes Apr 13, 2023
@maschad maschad requested a review from p-shahi April 14, 2023 00:27
@maschad maschad marked this pull request as ready for review April 14, 2023 00:28
@maschad maschad requested a review from thomaseizinger April 14, 2023 00:28
p-shahi
p-shahi reviewed Apr 14, 2023
View reviewed changes
p-shahi
p-shahi reviewed Apr 14, 2023
View reviewed changes
p-shahi
p-shahi approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@p-shahi p-shahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thank you so much

@p-shahi p-shahi changed the title Remaining fixes feat: UI fixes, persist messages, set up cxn limit Apr 14, 2023
@p-shahi p-shahi merged commit 8e44930 into main Apr 14, 2023
@thomaseizinger
Copy link
Contributor

Nice work!

Perhaps the first page could still have a few things renamed, now that it is completely passive.

I'll send a PR.

@DougAnderson444
Copy link
Contributor

I kind of liked being able to add a peerID/ MultiAddr on that first tab, what was the rationale behind removing it?

@maschad
Copy link
Member Author

maschad commented Apr 14, 2023 •
edited
Loading

I kind of liked being able to add a peerID/ MultiAddr on that first tab, what was the rationale behind removing it?

We now bootstrap to the deployed rust peer then dial the peers once they get added to the DHT , so there's no need to manually dial peers

@DougAnderson444
Copy link
Contributor

Ok perfect, I added a note in the README in my PR on how to connect to that via cli arg.

@p-shahi p-shahi deleted the ui-updates branch April 20, 2023 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-shahi p-shahi p-shahi approved these changes

@thomaseizinger thomaseizinger Awaiting requested review from thomaseizinger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maschad @thomaseizinger @DougAnderson444 @p-shahi