Skip to content

fix: add Gossipsub protocol to ALLOWED_PROTOCOLS in identify metrics #5992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Pronoss
Copy link

@Pronoss Pronoss commented Apr 17, 2025

This PR addresses a TODO by adding the GOSSIPSUB_PROTOCOL_ID from libp2p_gossipsub to the ALLOWED_PROTOCOLS list used in the identify metrics module.

Previously, the Gossipsub protocol was commented out with a TODO placeholder. Now, it's conditionally included when the gossipsub feature is enabled, ensuring metrics can correctly account for Gossipsub-supporting peers.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates (if needed)

@Pronoss Pronoss changed the title Add Gossipsub protocol to ALLOWED_PROTOCOLS in identify metrics fix: add Gossipsub protocol to ALLOWED_PROTOCOLS in identify metrics Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant