WIP: Add stage epf #96
Open
+143
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I wouldn't worry about that yet, we'll speed things up after we have a complete decoder :-)
How so? |
veluca93
reviewed
Jan 27, 2025
jxl/src/render/stages/epf.rs
Outdated
| /// (inverse) multiplier for sigma on borders | ||
| border_sad_mul: f32, | ||
| channel_scale: [f32; 3], | ||
| sigma: Arc<[f32]>, |
There was a problem hiding this comment.
Why is this not an Arc<Image>?
|
Just did some refactoring. The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a quick POC for easier stage 0. It seems to have a lot of offset manipulations so fingers crossed 🤞 for the compiler to get rid of the bound checks.
It's also awkward to work with the
rowtype since it's behind a large&mut[Channel]reference.