Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a first version of modular channel decoding. #92

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

veluca93
Copy link
Member

Does not support the Weighted predictor or prev-channel properties yet, and is not optimized.

@veluca93 veluca93 requested a review from mo271 January 22, 2025 22:05
@veluca93 veluca93 force-pushed the modular-simple-decoding branch 3 times, most recently from f1f1966 to 2a804c1 Compare January 22, 2025 22:27
Copy link
Member

@mo271 mo271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in general there are a few places where unwrap is used, I assume you have considered handling the potential panics there, and decided it is not needed.

@veluca93
Copy link
Member Author

in general there are a few places where unwrap is used, I assume you have considered handling the potential panics there, and decided it is not needed.

I believe all of those only trigger in case of bugs...

Does not support the Weighted predictor or prev-channel properties yet,
and is not optimized.
@veluca93 veluca93 force-pushed the modular-simple-decoding branch from 2a804c1 to 7bf2a3a Compare January 23, 2025 09:57
@veluca93 veluca93 merged commit 7b67dba into libjxl:main Jan 23, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants