Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated CI #253

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Updated CI #253

merged 2 commits into from
Feb 18, 2025

Conversation

johnnynunez
Copy link
Contributor

@johnnynunez johnnynunez commented Feb 14, 2025 •
edited
Loading

This pull request includes several updates to the CI/CD workflows and configuration files to enhance compatibility and streamline the build process. The most important changes include adding a new platform to the build matrix, refining the build and test steps, and updating the pyproject.toml file to specify architecture and image details.

CI/CD Workflow Updates:

  • .github/workflows/pip.yml: Added ubuntu-24.04-arm to the platform matrix to expand the build coverage.
  • .github/workflows/wheels.yml:
    • Consolidated and refined build steps for build_sdist and build_wheels jobs, ensuring failure on twine check errors and specifying architecture and Python builds at the top level for clarity.
    • Added a new release_artifacts job to handle artifact release on tag pushes, including downloading artifacts, listing them, and using release-action and gh-action-pypi-publish for publishing.

Configuration File Updates:

  • pyproject.toml:
    • Added archs = "auto64" to the cibuildwheel tool configuration to automatically detect the architecture.
    • Specified manylinux images for x86_64 and aarch64 to ensure consistent build environments.
      *Include Windows Arch build wheel.

@johnnynunez
Copy link
Contributor Author

cc @alecjacobson now it's working

@johnnynunez
Copy link
Contributor Author

cc @alecjacobson
image

@alecjacobson
Copy link
Contributor

Thanks. Is it easy to fix the } in the name of these:
image

also, is python 3.9 missing?

@johnnynunez
Copy link
Contributor Author

johnnynunez commented Feb 14, 2025 •
edited
Loading

Thanks. Is it easy to fix the } in the name of these: image

also, is python 3.9 missing?

I can add it if you want.. but will be deprecated soon, I've seen https://devguide.python.org/versions/
Maybe its better to add 3.13 and 3.14 in the future

@alecjacobson
Copy link
Contributor

alecjacobson commented Feb 14, 2025 via email

@johnnynunez
Copy link
Contributor Author

I think it'd be good to keep the same set that is already working (which I think also includes 3.8 on some platforms). -Alec
…
On Fri, Feb 14, 2025 at 12:14 PM Johnny @.> wrote: Thanks. Is it easy to fix the } in the name of these: [image: image] https://private-user-images.githubusercontent.com/2241689/413406016-0aa8bc78-6e16-4f55-bc15-b9c7dc9f7f52.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NTM1MzgsIm5iZiI6MTczOTU1MzIzOCwicGF0aCI6Ii8yMjQxNjg5LzQxMzQwNjAxNi0wYWE4YmM3OC02ZTE2LTRmNTUtYmMxNS1iOWM3ZGM5ZjdmNTIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTRUMTcxMzU4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NWRkNDk0MThhNDUzYjYzOTgxODQ5Y2QwNDE1YjNiNzViYzVkNjc1MDQyMmU5MTBiMTQ1MTM1NTJmNzhlNmMxZiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.ME1hG6Uql78QqJqbipulLAdHRbw3XoYE9BBBtrX5kpU also, is python 3.9 missing? I can add it if you want.. but will be deprecated soon, I've seen — Reply to this email directly, view it on GitHub <#253 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARDJGPZAMNJP2ZWQKEYRP32PYQANAVCNFSM6AAAAABXE4UOVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJZHA3DIMZVGU . You are receiving this because you were mentioned.Message ID: @.> [image: johnnynunez]johnnynunez left a comment (libigl/libigl-python-bindings#253) <#253 (comment)> Thanks. Is it easy to fix the } in the name of these: [image: image] https://private-user-images.githubusercontent.com/2241689/413406016-0aa8bc78-6e16-4f55-bc15-b9c7dc9f7f52.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NTM1MzgsIm5iZiI6MTczOTU1MzIzOCwicGF0aCI6Ii8yMjQxNjg5LzQxMzQwNjAxNi0wYWE4YmM3OC02ZTE2LTRmNTUtYmMxNS1iOWM3ZGM5ZjdmNTIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTRUMTcxMzU4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NWRkNDk0MThhNDUzYjYzOTgxODQ5Y2QwNDE1YjNiNzViYzVkNjc1MDQyMmU5MTBiMTQ1MTM1NTJmNzhlNmMxZiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.ME1hG6Uql78QqJqbipulLAdHRbw3XoYE9BBBtrX5kpU also, is python 3.9 missing? I can add it if you want.. but will be deprecated soon, I've seen — Reply to this email directly, view it on GitHub <#253 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARDJGPZAMNJP2ZWQKEYRP32PYQANAVCNFSM6AAAAABXE4UOVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJZHA3DIMZVGU . You are receiving this because you were mentioned.Message ID: @.***>

Okay, I will add again

@johnnynunez
Copy link
Contributor Author

Done, you can merge it if you want @alecjacobson

@johnnynunez
Copy link
Contributor Author

I think it'd be good to keep the same set that is already working (which I think also includes 3.8 on some platforms). -Alec
…
On Fri, Feb 14, 2025 at 12:14 PM Johnny @.> wrote: Thanks. Is it easy to fix the } in the name of these: [image: image] https://private-user-images.githubusercontent.com/2241689/413406016-0aa8bc78-6e16-4f55-bc15-b9c7dc9f7f52.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NTM1MzgsIm5iZiI6MTczOTU1MzIzOCwicGF0aCI6Ii8yMjQxNjg5LzQxMzQwNjAxNi0wYWE4YmM3OC02ZTE2LTRmNTUtYmMxNS1iOWM3ZGM5ZjdmNTIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTRUMTcxMzU4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NWRkNDk0MThhNDUzYjYzOTgxODQ5Y2QwNDE1YjNiNzViYzVkNjc1MDQyMmU5MTBiMTQ1MTM1NTJmNzhlNmMxZiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.ME1hG6Uql78QqJqbipulLAdHRbw3XoYE9BBBtrX5kpU also, is python 3.9 missing? I can add it if you want.. but will be deprecated soon, I've seen — Reply to this email directly, view it on GitHub <#253 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARDJGPZAMNJP2ZWQKEYRP32PYQANAVCNFSM6AAAAABXE4UOVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJZHA3DIMZVGU . You are receiving this because you were mentioned.Message ID: @.> [image: johnnynunez]johnnynunez left a comment (libigl/libigl-python-bindings#253) <#253 (comment)> Thanks. Is it easy to fix the } in the name of these: [image: image] https://private-user-images.githubusercontent.com/2241689/413406016-0aa8bc78-6e16-4f55-bc15-b9c7dc9f7f52.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NTM1MzgsIm5iZiI6MTczOTU1MzIzOCwicGF0aCI6Ii8yMjQxNjg5LzQxMzQwNjAxNi0wYWE4YmM3OC02ZTE2LTRmNTUtYmMxNS1iOWM3ZGM5ZjdmNTIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTRUMTcxMzU4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NWRkNDk0MThhNDUzYjYzOTgxODQ5Y2QwNDE1YjNiNzViYzVkNjc1MDQyMmU5MTBiMTQ1MTM1NTJmNzhlNmMxZiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.ME1hG6Uql78QqJqbipulLAdHRbw3XoYE9BBBtrX5kpU also, is python 3.9 missing? I can add it if you want.. but will be deprecated soon, I've seen — Reply to this email directly, view it on GitHub <#253 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARDJGPZAMNJP2ZWQKEYRP32PYQANAVCNFSM6AAAAABXE4UOVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJZHA3DIMZVGU . You are receiving this because you were mentioned.Message ID: @.***>

3.8 breaks CI

@alecjacobson
Copy link
Contributor

alecjacobson commented Feb 14, 2025 via email

@johnnynunez
Copy link
Contributor Author

Yeah I think it only worked on some os. Maybe check the ci before this pr?
…
On Fri, Feb 14, 2025, 2:48 PM Johnny @.> wrote: I think it'd be good to keep the same set that is already working (which I think also includes 3.8 on some platforms). -Alec … <#m_4223851792826506333_> On Fri, Feb 14, 2025 at 12:14 PM Johnny @.> wrote: Thanks. Is it easy to fix the } in the name of these: [image: image] https://private-user-images.githubusercontent.com/2241689/413406016-0aa8bc78-6e16-4f55-bc15-b9c7dc9f7f52.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NTM1MzgsIm5iZiI6MTczOTU1MzIzOCwicGF0aCI6Ii8yMjQxNjg5LzQxMzQwNjAxNi0wYWE4YmM3OC02ZTE2LTRmNTUtYmMxNS1iOWM3ZGM5ZjdmNTIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTRUMTcxMzU4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NWRkNDk0MThhNDUzYjYzOTgxODQ5Y2QwNDE1YjNiNzViYzVkNjc1MDQyMmU5MTBiMTQ1MTM1NTJmNzhlNmMxZiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.ME1hG6Uql78QqJqbipulLAdHRbw3XoYE9BBBtrX5kpU https://private-user-images.githubusercontent.com/2241689/413406016-0aa8bc78-6e16-4f55-bc15-b9c7dc9f7f52.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NTM1MzgsIm5iZiI6MTczOTU1MzIzOCwicGF0aCI6Ii8yMjQxNjg5LzQxMzQwNjAxNi0wYWE4YmM3OC02ZTE2LTRmNTUtYmMxNS1iOWM3ZGM5ZjdmNTIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTRUMTcxMzU4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NWRkNDk0MThhNDUzYjYzOTgxODQ5Y2QwNDE1YjNiNzViYzVkNjc1MDQyMmU5MTBiMTQ1MTM1NTJmNzhlNmMxZiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.ME1hG6Uql78QqJqbipulLAdHRbw3XoYE9BBBtrX5kpU also, is python 3.9 missing? I can add it if you want.. but will be deprecated soon, I've seen — Reply to this email directly, view it on GitHub <#253 (comment) <#253 (comment)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARDJGPZAMNJP2ZWQKEYRP32PYQANAVCNFSM6AAAAABXE4UOVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJZHA3DIMZVGU https://github.com/notifications/unsubscribe-auth/AARDJGPZAMNJP2ZWQKEYRP32PYQANAVCNFSM6AAAAABXE4UOVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJZHA3DIMZVGU . You are receiving this because you were mentioned.Message ID: @.> [image: johnnynunez]johnnynunez left a comment ( libigl/libigl-python-bindings#253 <#253>) <#253 (comment) <#253 (comment)>> Thanks. Is it easy to fix the } in the name of these: [image: image] https://private-user-images.githubusercontent.com/2241689/413406016-0aa8bc78-6e16-4f55-bc15-b9c7dc9f7f52.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NTM1MzgsIm5iZiI6MTczOTU1MzIzOCwicGF0aCI6Ii8yMjQxNjg5LzQxMzQwNjAxNi0wYWE4YmM3OC02ZTE2LTRmNTUtYmMxNS1iOWM3ZGM5ZjdmNTIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTRUMTcxMzU4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NWRkNDk0MThhNDUzYjYzOTgxODQ5Y2QwNDE1YjNiNzViYzVkNjc1MDQyMmU5MTBiMTQ1MTM1NTJmNzhlNmMxZiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.ME1hG6Uql78QqJqbipulLAdHRbw3XoYE9BBBtrX5kpU also, is python 3.9 missing? I can add it if you want.. but will be deprecated soon, I've seen — Reply to this email directly, view it on GitHub <#253 (comment) <#253 (comment)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARDJGPZAMNJP2ZWQKEYRP32PYQANAVCNFSM6AAAAABXE4UOVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJZHA3DIMZVGU . You are receiving this because you were mentioned.Message ID: @.> 3.8 breaks CI — Reply to this email directly, view it on GitHub <#253 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARDJGKG2ULZAQOEJSV77632PZCARAVCNFSM6AAAAABXE4UOVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRQGE2DANBWHA . You are receiving this because you were mentioned.Message ID: @.> [image: johnnynunez]johnnynunez left a comment (libigl/libigl-python-bindings#253) <#253 (comment)> I think it'd be good to keep the same set that is already working (which I think also includes 3.8 on some platforms). -Alec … <#m_4223851792826506333_> On Fri, Feb 14, 2025 at 12:14 PM Johnny @.> wrote: Thanks. Is it easy to fix the } in the name of these: [image: image] https://private-user-images.githubusercontent.com/2241689/413406016-0aa8bc78-6e16-4f55-bc15-b9c7dc9f7f52.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NTM1MzgsIm5iZiI6MTczOTU1MzIzOCwicGF0aCI6Ii8yMjQxNjg5LzQxMzQwNjAxNi0wYWE4YmM3OC02ZTE2LTRmNTUtYmMxNS1iOWM3ZGM5ZjdmNTIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTRUMTcxMzU4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NWRkNDk0MThhNDUzYjYzOTgxODQ5Y2QwNDE1YjNiNzViYzVkNjc1MDQyMmU5MTBiMTQ1MTM1NTJmNzhlNmMxZiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.ME1hG6Uql78QqJqbipulLAdHRbw3XoYE9BBBtrX5kpU https://private-user-images.githubusercontent.com/2241689/413406016-0aa8bc78-6e16-4f55-bc15-b9c7dc9f7f52.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NTM1MzgsIm5iZiI6MTczOTU1MzIzOCwicGF0aCI6Ii8yMjQxNjg5LzQxMzQwNjAxNi0wYWE4YmM3OC02ZTE2LTRmNTUtYmMxNS1iOWM3ZGM5ZjdmNTIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTRUMTcxMzU4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NWRkNDk0MThhNDUzYjYzOTgxODQ5Y2QwNDE1YjNiNzViYzVkNjc1MDQyMmU5MTBiMTQ1MTM1NTJmNzhlNmMxZiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.ME1hG6Uql78QqJqbipulLAdHRbw3XoYE9BBBtrX5kpU also, is python 3.9 missing? I can add it if you want.. but will be deprecated soon, I've seen — Reply to this email directly, view it on GitHub <#253 (comment) <#253 (comment)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARDJGPZAMNJP2ZWQKEYRP32PYQANAVCNFSM6AAAAABXE4UOVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJZHA3DIMZVGU https://github.com/notifications/unsubscribe-auth/AARDJGPZAMNJP2ZWQKEYRP32PYQANAVCNFSM6AAAAABXE4UOVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJZHA3DIMZVGU . You are receiving this because you were mentioned.Message ID: @.> [image: johnnynunez]johnnynunez left a comment ( libigl/libigl-python-bindings#253 <#253>) <#253 (comment) <#253 (comment)>> Thanks. Is it easy to fix the } in the name of these: [image: image] https://private-user-images.githubusercontent.com/2241689/413406016-0aa8bc78-6e16-4f55-bc15-b9c7dc9f7f52.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NTM1MzgsIm5iZiI6MTczOTU1MzIzOCwicGF0aCI6Ii8yMjQxNjg5LzQxMzQwNjAxNi0wYWE4YmM3OC02ZTE2LTRmNTUtYmMxNS1iOWM3ZGM5ZjdmNTIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTRUMTcxMzU4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NWRkNDk0MThhNDUzYjYzOTgxODQ5Y2QwNDE1YjNiNzViYzVkNjc1MDQyMmU5MTBiMTQ1MTM1NTJmNzhlNmMxZiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.ME1hG6Uql78QqJqbipulLAdHRbw3XoYE9BBBtrX5kpU also, is python 3.9 missing? I can add it if you want.. but will be deprecated soon, I've seen — Reply to this email directly, view it on GitHub <#253 (comment) <#253 (comment)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARDJGPZAMNJP2ZWQKEYRP32PYQANAVCNFSM6AAAAABXE4UOVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJZHA3DIMZVGU . You are receiving this because you were mentioned.Message ID: @.> 3.8 breaks CI — Reply to this email directly, view it on GitHub <#253 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARDJGKG2ULZAQOEJSV77632PZCARAVCNFSM6AAAAABXE4UOVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRQGE2DANBWHA . You are receiving this because you were mentioned.Message ID: @.*>

in arm is working, only docker failed, sometimes happens

@johnnynunez
Copy link
Contributor Author

Not exists python3.8 for arm64 macos

@alecjacobson
Copy link
Contributor

alecjacobson commented Feb 15, 2025 via email •
edited
Loading

@alecjacobson
Copy link
Contributor

1h42m vs 23m for reference

@johnnynunez
Copy link
Contributor Author

1h42m vs 23m for reference

Its windows...

@alecjacobson
Copy link
Contributor

alecjacobson commented Feb 16, 2025 via email

@johnnynunez
Copy link
Contributor Author

Is it possible to separate the "jobs" for each ".whl"? Like before. This parallelizes over the jobs and is much faster overall (even if each windows .whl is slower)
…
On Sat, Feb 15, 2025, 7:22 PM Johnny @.> wrote: 1h42m vs 23m for reference Its windows... — Reply to this email directly, view it on GitHub <#253 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARDJGNKR5MARLYIYRPSDE32P7K4FAVCNFSM6AAAAABXE4UOVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRRGE3DAOBXGU . You are receiving this because you were mentioned.Message ID: @.> [image: johnnynunez]johnnynunez left a comment (libigl/libigl-python-bindings#253) <#253 (comment)> 1h42m vs 23m for reference Its windows... — Reply to this email directly, view it on GitHub <#253 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARDJGNKR5MARLYIYRPSDE32P7K4FAVCNFSM6AAAAABXE4UOVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRRGE3DAOBXGU . You are receiving this because you were mentioned.Message ID: @.***>

yeah for sure!

@johnnynunez
Copy link
Contributor Author

Is it possible to separate the "jobs" for each ".whl"? Like before. This parallelizes over the jobs and is much faster overall (even if each windows .whl is slower)
…
On Sat, Feb 15, 2025, 7:22 PM Johnny @.> wrote: 1h42m vs 23m for reference Its windows... — Reply to this email directly, view it on GitHub <#253 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARDJGNKR5MARLYIYRPSDE32P7K4FAVCNFSM6AAAAABXE4UOVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRRGE3DAOBXGU . You are receiving this because you were mentioned.Message ID: @.> [image: johnnynunez]johnnynunez left a comment (libigl/libigl-python-bindings#253) <#253 (comment)> 1h42m vs 23m for reference Its windows... — Reply to this email directly, view it on GitHub <#253 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARDJGNKR5MARLYIYRPSDE32P7K4FAVCNFSM6AAAAABXE4UOVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRRGE3DAOBXGU . You are receiving this because you were mentioned.Message ID: @.***>

done! It’s fast again
IMG_2939

@johnnynunez
Copy link
Contributor Author

@alecjacobson for me all is done! Thank you for the repo and enjoy it :)

@johnnynunez
Copy link
Contributor Author

@alecjacobson will you merge it? And when will be new release?

@alecjacobson alecjacobson merged commit c4167ca into libigl:main Feb 18, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnnynunez @alecjacobson