add Credentials::SshKeyMemory (off v1.5.0.1) #956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to track why but I actually think this is the cause of libssh2/libssh2#1107... looking to see if it's something obvious. |
This fixes the `warning: undefining the allocator of T_DATA class Rugged::Commit` warnings that are common in ruby 3.2 builds
Remove alloc from defined classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub is not letting me create this PR against v1.5.0.1 which is the tag I branched off of...
Edit 1: looks like need to ensure libgit2 is compiled with
GIT_SSH_MEMORY_CREDENTIALSdefined...Edit 2: this may just be because it couldn't find libssh2 shared libs...
Edit 3: ^ correct, this feature is disabled if libssh2 shared libs are not found (was previously building static). Not sure how to enforce or check in rugged... looking for guidance but at least for my use case this works.