Simplify Config.Clone with {maps,slices}.Clone#1313
Merged
arp242 merged 1 commit intolib:masterfrom Apr 8, 2026
Merged
Conversation
arp242
force-pushed
the
simplify-config-clone
branch
from
ddc2ac9 to
4596db2
Compare
A small change in behaviour in that nil maps and slices will be preserved but if they were fine in the original Config it only makes sense that they'd be fine in the cloned Config. Using std library Clone functions in our Clone function has a nice symmetry.
arp242
force-pushed
the
simplify-config-clone
branch
from
4596db2 to
1b024b3
Compare
Collaborator
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small change in behaviour in that nil maps and slices will be preserved but if they were fine in the original Config it only makes sense that they'd be fine in the cloned Config. Using std library Clone functions in our Clone function has a nice symmetry.