Fix issue where overrideKeyForLookup will crash in release builds #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Xcode 26 we found that iOS 15 release builds started crashing when resolving interpolated localised strings. This turned out to be related to the generated
overrideKeyForLookup. Changing fromassumingMemoryReboundtowithMemoryReboundfixes the crash and doesn't seem to have any unexpected side effects. The strings still resolve to the expected values.This PR implements that fix.
However we also wondered if there is an alternative, for example while the generated
LocalizedStringKey.localizablepath ends up in theoverrideKeyForLookupmethod on iOS 15, theString.localizablepath does not. Is there a way to use the more direct and safer path fromString.localizable?In any event this PR should fix the issue we were experiencing.
Please let me know if you need anything from us. We do have a tiny example project illustrating the issue if you'd like to see it.