fix: disable nested parallel processing for chromatograms #602
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix addresses a comment in issue
sneumann/xcms#627 (comment).
chromatogram()
is extracting chromatograms in parallel for each sample/file. The internal function usesspectra()
to load the data in each parallel process. The default value forBPPARAM
ofspectra()
is howeverBPPARAM = bpparam()
, thus, an eventual nested (and unnecessary) parallel processing setup is created. This PR forces the internalspectra()
call to disable parallel processing.