Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: quest boost #361

Merged
merged 40 commits into from
Dec 11, 2023
Merged

feat: quest boost #361

merged 40 commits into from
Dec 11, 2023

Conversation

ayushtom
Copy link
Contributor

@ayushtom ayushtom commented Nov 24, 2023 •
edited
Loading

closes #356

@vercel Vercel
Copy link

vercel bot commented Nov 24, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
goerli-starknet-quest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2023 11:46am
starknet-quest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2023 11:46am

Th0rgal
Th0rgal requested changes Dec 11, 2023
View reviewed changes
app/quest-boost/[boostId]/page.tsx Outdated
calldata: claimCallData,
},
undefined,
{ maxFee: 900_000_000_000_000 }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have to specify this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

app/quest-boost/[boostId]/page.tsx Outdated
disabled={boost?.winner !== hexToDecimal(address)}
onClick={handleClaimClick}
>
{boost?.winner === hexToDecimal(address)
Copy link
Member

@Th0rgal Th0rgal Dec 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer something like that, chained ? operators are not easy to read:

        {(() => {
            if (boost?.winner === hexToDecimal(address)) {
                return "Claim boost reward 🎉 ";
            } else if (boost?.expiry > Date.now()) {
                return "Claim boost reward 🎉 ";
            } else {
                return "You’re not selected 🙁";
            }
        })()}

Also the message should probably not be Claim boost reward if the expiry is higher, but just that the boost has not ended

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@fricoben fricoben added ❌ Change request Change requested from reviewer and removed 🔥 Ready for review This pull request needs a review labels Dec 11, 2023
@ayushtom ayushtom requested a review from Th0rgal December 11, 2023 10:52
@ayushtom ayushtom added 🔥 Ready for review This pull request needs a review and removed ❌ Change request Change requested from reviewer labels Dec 11, 2023
Th0rgal
Th0rgal approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@Th0rgal Th0rgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

fricoben
fricoben approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@fricoben fricoben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fricoben fricoben merged commit 096c657 into testnet Dec 11, 2023
2 checks passed
fricoben added a commit that referenced this pull request Dec 18, 2023
@fricoben @ayushtom
@Th0rgal @codeWhizperer
MEP 18/12/2023 (#426)
560b6b3 
* test: cdn code change

* fix: update cdn check

* feat: add rhino image (#413)

* feat: quest boost (#361)

* feat: add base layout

* feat: add contract call base

* feat: add api calls v1

* feat: park changes

* feat: api integration

* chore: add types

* feat: add build fix and expiry timer

* chore: fix types

* feat: update button text conditions

* feat: add contract in quest boost

* feat: add api calls

* feat: add updated changes

* chore: add changes

* chore: revert rpc changes

* chore: button title change

* feat: add final changes

* chore: add types

* fix: design changes

* feat: update contract

* chore: remove decimal representation on contract address

* fix: claim button copy

* fix: mobile view styling

* fix: align expired tag

* fix: expired condition change

* feat: update with new boost info and resolve pr comments

* chore: resolve pr comments

* chore: update types

* chore: fix types

* fix: sign check

* chore: update starknet js version

* test: starknet js contract call

* fix: test account call

* fix: remove extra calls

* test: add abi and test

* test: update abi

* chore: remove extra code

* fix: update abi params in account.execute

* chore: resolve pr comments

* fix: handle claimed status

* test: remove undefined

* fix: remove timer on expiry and winner check fix (#419)

* fix: remove timer on expiry

* fix: timer check

* fix: remove decimal conversion

* fix: add claim  button flag (#420)

* feat: add quests favicon (#422)

* feat: bootstrap project with absolute-import (#423)

* feat: add rich UI on boost (#421)

* feat: add rich UI

* fix: change copy

* fix: length  on word check

* fix: expiry check

* feat: add notification support

* fix: remove timer check

* feat: add title styling

* fix: add correct address check

* fix: address to send

* feat: add absolute imports

* fix: tests config

* fix: mobile responsive

* fix: number formatting

---------

Co-authored-by: ayushtom <[email protected]>
Co-authored-by: Thomas Marchand <[email protected]>
Co-authored-by: Ayush Tomar <[email protected]>
Co-authored-by: Adegbite Ademola Kelvin <[email protected]>
fricoben added a commit that referenced this pull request Dec 18, 2023
@fricoben @ayushtom
@Th0rgal @codeWhizperer
MEP 18/12/2023 2 (#428)
a70e0dd 
* test: cdn code change

* fix: update cdn check

* feat: add rhino image (#413)

* feat: quest boost (#361)

* feat: add base layout

* feat: add contract call base

* feat: add api calls v1

* feat: park changes

* feat: api integration

* chore: add types

* feat: add build fix and expiry timer

* chore: fix types

* feat: update button text conditions

* feat: add contract in quest boost

* feat: add api calls

* feat: add updated changes

* chore: add changes

* chore: revert rpc changes

* chore: button title change

* feat: add final changes

* chore: add types

* fix: design changes

* feat: update contract

* chore: remove decimal representation on contract address

* fix: claim button copy

* fix: mobile view styling

* fix: align expired tag

* fix: expired condition change

* feat: update with new boost info and resolve pr comments

* chore: resolve pr comments

* chore: update types

* chore: fix types

* fix: sign check

* chore: update starknet js version

* test: starknet js contract call

* fix: test account call

* fix: remove extra calls

* test: add abi and test

* test: update abi

* chore: remove extra code

* fix: update abi params in account.execute

* chore: resolve pr comments

* fix: handle claimed status

* test: remove undefined

* fix: remove timer on expiry and winner check fix (#419)

* fix: remove timer on expiry

* fix: timer check

* fix: remove decimal conversion

* fix: add claim  button flag (#420)

* feat: add quests favicon (#422)

* feat: bootstrap project with absolute-import (#423)

* feat: add rich UI on boost (#421)

* feat: add rich UI

* fix: change copy

* fix: length  on word check

* fix: expiry check

* feat: add notification support

* fix: remove timer check

* feat: add title styling

* fix: add correct address check

* fix: address to send

* feat: add absolute imports

* fix: tests config

* fix: mobile responsive

* fix: number formatting

* feat: add mobile responsive button and banner fix (#427)

---------

Co-authored-by: ayushtom <[email protected]>
Co-authored-by: Thomas Marchand <[email protected]>
Co-authored-by: Ayush Tomar <[email protected]>
Co-authored-by: Adegbite Ademola Kelvin <[email protected]>
fricoben added a commit that referenced this pull request Dec 30, 2023
@fricoben @ayushtom
@Th0rgal @codeWhizperer @Marchand-Nicolas
MEP 30/12/2022 (#435)
3a437ad 
* test: cdn code change

* fix: update cdn check

* feat: add rhino image (#413)

* feat: quest boost (#361)

* feat: add base layout

* feat: add contract call base

* feat: add api calls v1

* feat: park changes

* feat: api integration

* chore: add types

* feat: add build fix and expiry timer

* chore: fix types

* feat: update button text conditions

* feat: add contract in quest boost

* feat: add api calls

* feat: add updated changes

* chore: add changes

* chore: revert rpc changes

* chore: button title change

* feat: add final changes

* chore: add types

* fix: design changes

* feat: update contract

* chore: remove decimal representation on contract address

* fix: claim button copy

* fix: mobile view styling

* fix: align expired tag

* fix: expired condition change

* feat: update with new boost info and resolve pr comments

* chore: resolve pr comments

* chore: update types

* chore: fix types

* fix: sign check

* chore: update starknet js version

* test: starknet js contract call

* fix: test account call

* fix: remove extra calls

* test: add abi and test

* test: update abi

* chore: remove extra code

* fix: update abi params in account.execute

* chore: resolve pr comments

* fix: handle claimed status

* test: remove undefined

* fix: remove timer on expiry and winner check fix (#419)

* fix: remove timer on expiry

* fix: timer check

* fix: remove decimal conversion

* fix: add claim  button flag (#420)

* feat: add quests favicon (#422)

* feat: bootstrap project with absolute-import (#423)

* feat: add rich UI on boost (#421)

* feat: add rich UI

* fix: change copy

* fix: length  on word check

* fix: expiry check

* feat: add notification support

* fix: remove timer check

* feat: add title styling

* fix: add correct address check

* fix: address to send

* feat: add absolute imports

* fix: tests config

* fix: mobile responsive

* fix: number formatting

* feat: add mobile responsive button and banner fix (#427)

* feat: mobile screen redesign (#425)

* feat: redesigning popups

* improving margin

* feat: redesigning partnership page

* feat: quest page redesign for mobile

* feat: back button redesign for mobile

* improving issuer

* feat: menu redesign for mobile

* fixing land margin

* fixing land paddings

* fixing land gaps

* fixing featured quest banner on some browsers

* fixing profile margins

* removing typing mistake

* fixing profile scroll on mobile

* fix logo in nav animation

* fix margin for category subtitles

* cleaning the code

* fix: add design fixes and api calls reduce in leaderboard (#431)

* fix: add design fixes and api calls reduce in leaderboard

* feat: add ui changes

* fix: build fails

* fix: utils

* feat: add optimisations

* chore: resolve comments and resolve build issue

* chore: remove logs

* feat: add boosted quests tag (#434)

---------

Co-authored-by: ayushtom <[email protected]>
Co-authored-by: Thomas Marchand <[email protected]>
Co-authored-by: Ayush Tomar <[email protected]>
Co-authored-by: Adegbite Ademola Kelvin <[email protected]>
Co-authored-by: Nico <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Th0rgal Th0rgal Th0rgal approved these changes

@fricoben fricoben fricoben approved these changes

@Marchand-Nicolas Marchand-Nicolas Awaiting requested review from Marchand-Nicolas

@irisdv irisdv Awaiting requested review from irisdv

Assignees

@ayushtom ayushtom

Labels
🔥 Ready for review This pull request needs a review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Quests boosts
4 participants
@ayushtom @irisdv @Th0rgal @fricoben