Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: update dynamic meta tags on quest pages #315

Merged
merged 35 commits into from
Nov 15, 2023
Merged

ref: update dynamic meta tags on quest pages #315

merged 35 commits into from
Nov 15, 2023

Conversation

irisdv
Copy link
Collaborator

@irisdv irisdv commented Nov 1, 2023 •
edited
Loading

Close #309

This PR :

  • updates to next.js v14, adding a new app directory that replaces our current pages directory
  • adds dynamic meta tags for quests pages

@vercel Vercel
Copy link

vercel bot commented Nov 1, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
goerli-starknet-quest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2023 5:24pm
starknet-quest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2023 5:24pm

@irisdv irisdv changed the title ref: update dynamic meta tags ref: update dynamic meta tags on quest pages Nov 1, 2023
@irisdv irisdv added the 🚧 In progress do not merge Pull Request in progress, please do not merge label Nov 1, 2023
@irisdv irisdv added 🔥 Ready for review This pull request needs a review and removed 🚧 In progress do not merge Pull Request in progress, please do not merge labels Nov 1, 2023
@irisdv irisdv requested a review from fricoben November 1, 2023 12:47
@irisdv irisdv added 🔥 Ready for review This pull request needs a review and removed ❌ Change request Change requested from reviewer labels Nov 15, 2023
@irisdv irisdv requested a review from fricoben November 15, 2023 14:02
ayushtom
ayushtom reviewed Nov 15, 2023
View reviewed changes
@ayushtom
Copy link
Contributor

Lgtm

@fricoben fricoben merged commit 410ad7b into testnet Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayushtom ayushtom ayushtom approved these changes

@fricoben fricoben Awaiting requested review from fricoben

Assignees
No one assigned
Labels
🔥 Ready for review This pull request needs a review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add custom title, description and image in quest page metatags
3 participants
@irisdv @ayushtom @fricoben