-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add leaderboard FE #254
Conversation
@ayushtom is attempting to deploy a commit to the StarknetID Team on Vercel. To accomplish this, @ayushtom needs to request access to the Team. Afterwards, an owner of the Team is required to accept their membership request. If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account. |
b7bc89c
to
79ea66a
Compare
I noticed that i have used tailwind classes. Will replace them with css styling in next commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super cool ! Some comments and questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 - Can we add an hover state/animation ?
1 - Add top padding on mobile like 24px
1 - Does the period filter work?
https://github.com/starknet-id/starknet.quest/assets/144677881/8760e8d6-b1c5-45c3-898f-0dd3670ed08c
1 - I believe you can only perform a search by typing the user's name exactly.
Is it possible to display the list letter by letter? Something like that
Thanks ! looks very good
1 - Does the period filter work? yes. The data is updated 2 days back all at once. So the date is filter can not filter on 7 days yet. Will take some time for data to have different timestamps. 1 - I believe you can only perform a search by typing the user's name exactly. |
Design and code is reviewed and approved. |
394b58a
to
1d2c719
Compare
1d2c719
to
726b41c
Compare
726b41c
to
488222d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
closes #250
closes #222
closes #251