Fix: Redirect to quest dashboard using router.push and remove handlePagination #1022
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@GradleD is attempting to deploy a commit to the LFG Labs Team on Vercel. A member of the Team first needs to authorize it. |
|
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
app/admin/quests/create/page.tsxOops! Something went wrong! :( ESLint: 9.17.0 ESLint couldn't find an eslint.config.(js|mjs|cjs) file. From ESLint v9.0.0, the default configuration file is now eslint.config.js. https://eslint.org/docs/latest/use/configure/migration-guide If you still have problems after following the migration guide, please stop by WalkthroughThe pull request modifies the Changes
Assessment against linked issues
The changes fully address the requirements specified in issue #1021, implementing the requested redirection mechanism and removing the previous pagination call. Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
app/admin/quests/create/page.tsx (2)
254-258: Extract tab parameter to a constantThe tab parameter is hardcoded in the URL. Consider extracting it to a constant for better maintainability.
+const DEFAULT_DASHBOARD_TAB = "tasks"; + const handleQuestAndBoostCreate = useCallback(async () => { // ... - router.push(`/admin/quests/dashboard/${id}?tab=tasks`); + router.push(`/admin/quests/dashboard/${id}?tab=${DEFAULT_DASHBOARD_TAB}`);
256-257: Add success notification before redirectConsider showing a success notification before redirecting to provide immediate feedback to the user.
+ showNotification("Quest created successfully", "success"); // Redirect to the quest dashboard using the quest ID router.push(`/admin/quests/dashboard/${id}?tab=tasks`);
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
app/admin/quests/create/page.tsx(1 hunks)
🔇 Additional comments (1)
app/admin/quests/create/page.tsx (1)
259-259: LGTM!The dependency array correctly includes all required dependencies for the callback.
|
|
||
| await handleCreateBoost(id); | ||
| await handleCreateNftUri(id); | ||
| await setButtonLoading(false); | ||
| handlePagination("Next"); | ||
| }, [questInput, boostInput, nfturi]); | ||
|
|
There was a problem hiding this comment.
Add error handling for async operations
The async operations lack proper error handling. If any operation fails, the loading state remains active and the user receives no feedback.
Consider wrapping the operations in a try-catch block:
- await handleCreateBoost(id);
- await handleCreateNftUri(id);
+ try {
+ await handleCreateBoost(id);
+ await handleCreateNftUri(id);
+ } catch (error) {
+ setButtonLoading(false);
+ showNotification("Failed to create quest components", "error");
+ console.error("Error creating quest components:", error);
+ return;
+ }Committable suggestion skipped: line range outside the PR's diff.
Redirect the admin after quest creation
Resolves: #1021
Summary by CodeRabbit
New Features
User Experience