Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing lff formatting issues by running lff and excluding intentionally failing example in zero delay cycles examples #120

Merged
merged 3 commits into from
Feb 8, 2025

Conversation

hokeun
Copy link
Member

@hokeun hokeun commented Feb 7, 2025

This PR partially fixes issues of failing lff checks in CI tests. See #119 for more details.

I ran lff commands for the following examples:

  • /examples/C/src/zero-delay-cycles/Consistency.lf
  • /examples/C/src/zero-delay-cycles/ZeroDelayCycle.lf

Now lff --check passes for the examples above.
However, there is still one remaining example with lff check issues:

  • /examples/C/src/zero-delay-cycles/CausalityLoop.lf

This will need more work.

@hokeun hokeun requested review from edwardalee and lhstrh February 7, 2025 19:43
Copy link
Contributor

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. May as well merge and continue fixes...

lhstrh
lhstrh previously requested changes Feb 7, 2025
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The remaining errors thrown by check-format aren't actually formatting issues but correctness issues. It's a program called CausalityLoop.lf with has, well..., a causality loop in it, which is not allowed by the compiler. I suppose that program exists to illustrate the issue of causality loops, but then we shouldn't insist it being a correct program. Note that action-check-lf-files action has an exclude_dirs argument that allows you to specify directories that are not checked. I believe it defaults to '["failing", "experimental"]'. So just put the CausalityLoop.lf in a directory called failing, and the check should pass...

@hokeun hokeun changed the title Fix lff formatting issues in zero delay cycles examples by running lff Fixing lff formatting issues by running lff and excluding intentionally failing example in zero delay cycles examples Feb 7, 2025
@hokeun
Copy link
Member Author

hokeun commented Feb 7, 2025

So just put the CausalityLoop.lf in a directory called failing, and the check should pass...

Thanks. Hope my change is aligned with what you wanted.

@hokeun hokeun dismissed lhstrh’s stale review February 7, 2025 23:26

Requested change has been made.

Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hokeun hokeun merged commit bde8b37 into main Feb 8, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants