Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web socket upgrade #101

Merged
merged 24 commits into from
Mar 8, 2024
Merged

Web socket upgrade #101

merged 24 commits into from
Mar 8, 2024

Conversation

edwardalee
Copy link
Contributor

This PR updates the browser-ui examples in the playground to add documentation and to add an easier-to-use WebSocketServerString reactor to the library.

@edwardalee edwardalee added the enhancement New feature or request label Feb 24, 2024
lhstrh
lhstrh approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really nice! I've changed CI to look at master for the compile checks so that we can get the tests to pass...

@edwardalee
Copy link
Contributor Author

Test failures here are due to new release, so I'm merging this to start helping @Aneeshi, who has a PR that to fix most of them.

@edwardalee edwardalee merged commit 85e9e6a into main Mar 8, 2024
3 of 5 checks passed
@edwardalee edwardalee deleted the web-socket-upgrade branch March 8, 2024 02:23
@cmnrd cmnrd mentioned this pull request Mar 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhstrh lhstrh lhstrh approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edwardalee @lhstrh