Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zero delay cycles examples failing in CI tests #119

Open
hokeun opened this issue Feb 7, 2025 · 0 comments
Open

Zero delay cycles examples failing in CI tests #119

hokeun opened this issue Feb 7, 2025 · 0 comments

Comments

@hokeun
Copy link
Member

hokeun commented Feb 7, 2025

I found this issue when I was reviewing a PR.

These following examples under zero-delay-cycles directory seem to be failing in lff --check tests in the CI:

  • /examples/C/src/zero-delay-cycles/CausalityLoop.lf
  • /examples/C/src/zero-delay-cycles/Consistency.lf
  • /examples/C/src/zero-delay-cycles/ZeroDelayCycle.lf

Here is an example of error messages for the failing tests:

❌ ./examples/C/src/zero-delay-cycles/CausalityLoop.lf
Error: Error: Command failed: lff --check "./examples/C/src/zero-delay-cycles/CausalityLoop.lf"
lff: error: Cyclic dependency due to succeeding reaction. Consider reordering reactions within reactor Controller to avoid causality loop.
 --> examples/C/src/zero-delay-cycles/CausalityLoop.lf:18:3
   |
17 | 
   | >>>>>>>>>>>>>>
18 |   reaction a1(planning) {=
19 |     self->plan = planning->value;
20 |   =}
   | <<<< Cyclic dependency due to succeeding reaction. Consider reordering reactions within reactor Controller to avoid causality loop.
21 | 

lff: error: Reaction triggers involved in cyclic dependency in reactor Controller: planning.
 --> examples/C/src/zero-delay-cycles/CausalityLoop.lf:18:15
   |
17 | 
18 |   reaction a1(planning) {=
   |               ^^^^^^^^ Reaction triggers involved in cyclic dependency in reactor Controller: planning.
   |
19 |     self->plan = planning->value;

lff: error: Cyclic dependency due to preceding reaction. Consider reordering reactions within reactor Controller to avoid causality loop.
 --> examples/C/src/zero-delay-cycles/CausalityLoop.lf:22:3
   |
21 | 
   | >>>>>>>>>>>>>>
22 |   reaction a2(sensor) -> request_for_planning, control {=
23 |     lf_set(request_for_planning, sensor->value);
   | ...
24 |     lf_set(control, self->plan);
25 |   =}
   | <<<< Cyclic dependency due to preceding reaction. Consider reordering reactions within reactor Controller to avoid causality loop.
26 | }

lff: error: Reaction effects involved in cyclic dependency in reactor Controller: request_for_planning, control.
 --> examples/C/src/zero-delay-cycles/CausalityLoop.lf:22:26
   |
21 | 
22 |   reaction a2(sensor) -> request_for_planning, control {=
   |                          ^^^^^^^^^^^^^^^^^^^^ Reaction effects involved in cyclic dependency in reactor Controller: request_for_planning, control.
   |
23 |     lf_set(request_for_planning, sensor->value);

lff: fatal error: Aborting due to 4 previous errors.

❌ ./examples/C/src/zero-delay-cycles/Consistency.lf
Error: Error: Command failed: lff --check "./examples/C/src/zero-delay-cycles/Consistency.lf"
lff: error: Would reformat /home/runner/work/playground-lingua-franca/playground-lingua-franca/examples/C/src/zero-delay-cycles/Consistency.lf
lff: info: Done formatting.

✔️ ./examples/C/src/zero-delay-cycles/Feedback.lf
❌ ./examples/C/src/zero-delay-cycles/ZeroDelayCycle.lf
Error: Error: Command failed: lff --check "./examples/C/src/zero-delay-cycles/ZeroDelayCycle.lf"
lff: error: Would reformat /home/runner/work/playground-lingua-franca/playground-lingua-franca/examples/C/src/zero-delay-cycles/ZeroDelayCycle.lf
lff: info: Done formatting.

You can also check the error messages here: https://github.com/lf-lang/playground-lingua-franca/actions/runs/13189967620/job/36865083693?pr=118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant