Add option for custom rxPin and txPin with HardwareSerial (e.g. for ESP32) #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sync fork
while keeping existing API for SoftwareSerial
cyberman54
changed the title
lewapek
reviewed
Feb 22, 2022
| void begin(int baudRate) { | ||
| serial.begin(baudRate); | ||
| void begin(int baudRate = 9600, uint32_t config = SERIAL_8N1, int pinRx = -1, int pinTx = -1) { | ||
| serial.begin(baudRate, config, pinRx, pinTx); |
There was a problem hiding this comment.
esp32 HardwareSerial is different - and if you try to compile for arduino this would not work
the solution is to put you modified API (with additional params) behind preprocessor directive so it's compiled only in case of esp32
lewapek
reviewed
Feb 22, 2022
| abstractSerial->begin(baudRate); | ||
| } | ||
| void begin(int baudRate = 9600, uint32_t config = SERIAL_8N1, int pinRx = -1, int pinTx = -1) { | ||
| abstractSerial->begin(baudRate, config, pinRx, pinTx); |
There was a problem hiding this comment.
let's keep 2 spaces indentation to be consistent with the rest of the project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESP32 boards support remapping of GPIO pins to Serial ports (UART0/1/2).
This PR enhances API in Serial.h with an option to pass custom rxPin and txPin to HardwareSerial. It keeps all usage options of the former API (i.e. for using SoftwareSerial), so this change shouldn't break any code created before this PR.