Skip to content

Add SPKIHash to issuanceEvent Audit logs. #9014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ezekiel wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −0
Draft

Add SPKIHash to issuanceEvent Audit logs. #9014

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ca/ca.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ type issuanceEvent struct {
OrderID int64
Profile string
Issuer string
SPKIHash string
IssuanceRequest *issuance.IssuanceRequest
CSR string `json:",omitempty"`
Result issuanceEventResult
Expand Down Expand Up @@ -252,6 +253,11 @@ func (ca *certificateAuthorityImpl) IssueCertificate(ctx context.Context, req *c
return nil, fmt.Errorf("computing subject key ID: %w", err)
}

subjectKeyDigest, err := core.KeyDigest(csr.PublicKey)
if err != nil {
return nil, fmt.Errorf("computing subject key info hash: %w", err)
}

dnsNames, ipAddresses, err := identifier.FromCSR(csr).ToValues()
if err != nil {
return nil, err
Expand Down Expand Up @@ -329,6 +335,7 @@ func (ca *certificateAuthorityImpl) IssueCertificate(ctx context.Context, req *c
OrderID: req.OrderID,
Profile: req.CertProfileName,
Issuer: issuer.Name(),
SPKIHash: fmt.Sprintf("%x", subjectKeyDigest[:]),
IssuanceRequest: precertReq,
CSR: hex.EncodeToString(csr.Raw),
})
Expand All @@ -346,6 +353,7 @@ func (ca *certificateAuthorityImpl) IssueCertificate(ctx context.Context, req *c
OrderID: req.OrderID,
Profile: req.CertProfileName,
Issuer: issuer.Name(),
SPKIHash: fmt.Sprintf("%x", subjectKeyDigest[:]),
IssuanceRequest: precertReq,
Result: issuanceEventResult{Precertificate: hex.EncodeToString(precertDER)},
})
Expand Down Expand Up @@ -407,6 +415,7 @@ func (ca *certificateAuthorityImpl) IssueCertificate(ctx context.Context, req *c
OrderID: req.OrderID,
Profile: req.CertProfileName,
Issuer: issuer.Name(),
SPKIHash: fmt.Sprintf("%x", subjectKeyDigest[:]),
IssuanceRequest: certReq,
})

Expand All @@ -424,6 +433,7 @@ func (ca *certificateAuthorityImpl) IssueCertificate(ctx context.Context, req *c
OrderID: req.OrderID,
Profile: req.CertProfileName,
Issuer: issuer.Name(),
SPKIHash: fmt.Sprintf("%x", subjectKeyDigest[:]),
IssuanceRequest: certReq,
Result: issuanceEventResult{Certificate: hex.EncodeToString(certDER)},
})
Expand Down