Skip to content

HTTP-01: Do our own redirect handling #8961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aarongable wants to merge 6 commits into
base: main
Choose a base branch
from
+780 −791
Open

HTTP-01: Do our own redirect handling #8961

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
af710a3
va: Handle IPv4 fallback for HTTP(S) redirects
sheurich Jul 25, 2026
e052398
Merge branch 'origin/main' into simplify-http-loop
aarongable Aug 19, 2026
12e91fd
HTTP-01: Do our own redirect handling
aarongable Aug 20, 2026
c68ce88
Respond to review comments
aarongable Sep 2, 2026
f4c3495
And update unit tests accordingly
aarongable Sep 2, 2026
b02efb2
review comment
aarongable Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/v2_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ def test_http_challenge_broken_redirect():
redirect)

# Expect the specialized error message
expectedError = "64.112.117.122: Fetching {0}: Invalid host in redirect target \"{1}.well-known\". Check webserver config for missing '/' in redirect target.".format(redirect, d)
expectedError = "64.112.117.122: Fetching {0}: invalid host in redirect target \"{1}.well-known\": check webserver config for missing '/' in redirect target".format(redirect, d)

# NOTE(@cpu): Can't use chisel2.expect_problem here because it doesn't let
# us interrogate the detail message easily.
Expand Down
Loading