Refactor GetSCTs to use a single loop with a ticker #8470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a small refactor to remove a pair of closures so we can directly launch the submission goroutines with `go ctp.getOne(...)`. This is itself pulled out of a slightly larger refactor which pulls the stagger sleep back out of this function, but it's much cleaner to do this refactor as a preliminary change. There is a small functional change here: The same subCtx is passed to the submission RPC. I think that shouldn't cause any problems.
Instead of spawning all goroutines immediately with their own sleeps, this uses a ticker on the stagger interval to start additional submissions. This shouldn't change much, but unblocks future improvements like kicking off additional submissions immediately on failure to submit to a log, or adding more logic to what order we submit in based on the current results. As a small perf win, this should slightly decrease the number of goroutines as we don't typically have to submit to too many logs.
mcpherrinm
commented
Oct 30, 2025
mcpherrinm
requested review from
beautifulentropy
and removed request for
a team
aarongable
reviewed
Oct 30, 2025
Contributor
aarongable
left a comment
aarongable
left a comment
There was a problem hiding this comment.
Heck yes, I'm really happy you found a way to make this ticker-based instead of kicking off all the goroutines at once. This is going to make future changes so much easier.
keep it closer to initialization
Avoid mutating it
len(logs) no longer changes
mcpherrinm
commented
Nov 4, 2025
mcpherrinm
commented
Nov 4, 2025
This was needed when an earlier version of this code was mutating logs. Since it isn't needed anymore, we can just inline it.
This makes a bit more sense where the check is
aarongable
approved these changes
Nov 4, 2025
beautifulentropy
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of spawning all goroutines immediately with their own sleeps, this uses a ticker on the stagger interval to start additional submissions.
This shouldn't change much, but unblocks future improvements like kicking off additional submissions immediately on failure to submit to a log, or adding more logic to what order we submit in based on the current results.
As a small perf win, this should slightly decrease the number of goroutines as we don't typically have to submit to too many logs.