Skip to content

Conversation

Krinkle
Copy link

@Krinkle Krinkle commented Jul 15, 2024

What:

Remove unused parsers.entities.propertyCurly()

Why:

Follows-up a38f8a1 (#3163), which introduced this as part of implementing property accessors. The method was not used there, and hasn't been used elsewhere since then either.

This was found by @polishdeveloper during recent work on https://github.com/wikimedia/less.php.

Checklist:

  • Documentation: N/A
  • Added/updated unit tests: N/A
  • Code complete

Follows-up a38f8a1, which introduced
this as part of implementing property accessors. The method was not
used there, and hasn't been used elsewhere since then either.

Ref less#3163.
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 15, 2024
@matthew-dean
Copy link
Member

Oh it should probably be added to other parsers if its currently un-used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants