added test case for when a queue is passed to 'enqueue_in_with_queue' wh...#77
Open
nata79 wants to merge 1 commit intoleshill:masterfrom
nata79:master
Open
added test case for when a queue is passed to 'enqueue_in_with_queue' wh...#77nata79 wants to merge 1 commit intoleshill:masterfrom nata79:master
nata79 wants to merge 1 commit intoleshill:masterfrom
nata79:master
Conversation
… which is the same as the one defined in the class removed '_scheduled' keyword from queue names
Owner
|
Hi @nata79, Sorry about the delay in getting around to this. Scheduler takes a job and stores it elsewhere, and then moves it to a queue when the schedule indicates. In Is there something else that might work with your specs? When using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I developed a proxy to abstract our code base from the background-processing library, which always calls the 'enqueue_in_with_queue' method.
The problem is that sometimes the queue name, it passes, is also defined inside the worker class (with an instance variable) and our specs are written like this "ResqueSpec.schedule_for(NameFromClassMethod).should_not be_empty". This causes our tests to break because the 'schedule_queue_name' always append '_scheduled' to the queue name. Removing this works fine for me and is not breaking any other test, so I suppose it's fine, since I also did not find any reference to it the resque_scheduler gem.