Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TitleBarButton: Fix Foreground not using property value at initial #1017

Merged
merged 1 commit into from
Mar 26, 2024
Merged

TitleBarButton: Fix Foreground not using property value at initial #1017

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Wpf.Ui/Controls/TitleBar/TitleBarButton.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,14 +110,15 @@
{
DependencyPropertyDescriptor
.FromProperty(ButtonsForegroundProperty, typeof(Brush))
.RemoveValueChanged(this, OnButtonsForegroundChanged);

Check warning on line 113 in src/Wpf.Ui/Controls/TitleBar/TitleBarButton.cs

View workflow job for this annotation

GitHub Actions / build 

Nullability of reference types in type of parameter 'sender' of 'void TitleBarButton.OnButtonsForegroundChanged(object sender, EventArgs e)' doesn't match the target delegate 'EventHandler' (possibly because of nullability attributes).
}

private void TitleBarButton_Loaded(object sender, RoutedEventArgs e)
{
RenderButtonsForeground = ButtonsForeground;
DependencyPropertyDescriptor
.FromProperty(ButtonsForegroundProperty, typeof(Brush))
.AddValueChanged(this, OnButtonsForegroundChanged);

Check warning on line 121 in src/Wpf.Ui/Controls/TitleBar/TitleBarButton.cs

View workflow job for this annotation

GitHub Actions / build 

Nullability of reference types in type of parameter 'sender' of 'void TitleBarButton.OnButtonsForegroundChanged(object sender, EventArgs e)' doesn't match the target delegate 'EventHandler' (possibly because of nullability attributes).
}

private void OnButtonsForegroundChanged(object sender, EventArgs e)
Expand Down
Loading