Housekeeping #13
Open
Housekeeping #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also don't tell us that you do, when you don't. It points to node machine, instead of vm, anyway, so it is useless in most cases.
Just apply simple changes, useful and inherit the rest from base template. The old code didn't even want to run, so scrapped.
Noise ];-}
Avoids crashes on `vagrant destroy`.
For stable, unique hostnames across the system
thigg
force-pushed
the
housekeeping-pr
branch
from
e146ffd to
f32eb43
Compare
thigg
force-pushed
the
housekeeping-pr
branch
from
f32eb43 to
b83c116
Compare
|
any chance to get this merged? |
|
I dragged all of this into a single PR, I could also separate them, if you prefer it. |
|
bump |
It's okay, like it is. I will have a look within a few days! |
|
bump |
1 similar comment
|
bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some Housekeeping to start with.
I only did a quick review of the changes from DataxPL, but I ran with them for over a year and didnt encounter any specific problems.