Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCM / FileDB improvements #120

Merged
merged 7 commits into from
Mar 16, 2025
Merged

TCM / FileDB improvements #120

merged 7 commits into from
Mar 16, 2025

Conversation

gipert
Copy link
Member

@gipert gipert commented Mar 15, 2025

No description provided.

Copy link

codecov bot commented Mar 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.

Project coverage is 42.10%. Comparing base (4c5c933) to head (9608bc0).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...orkflow/src/legenddataflow/scripts/complete_run.py 0.00% 26 Missing ⚠️
workflow/src/legenddataflow/scripts/filedb.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
- Coverage   42.20%   42.10%   -0.11%     
==========================================
  Files          19       19              
  Lines        1206     1209       +3     
==========================================
  Hits          509      509              
- Misses        697      700       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gipert
Copy link
Member Author

gipert commented Mar 16, 2025

The CI failure is due to recent Snakemake versions: https://github.com/snakemake/snakemake/releases/tag/v9.0.0

I don't understand how to fix it... @ggmarshall there's maybe something nice about reports in the latest release

@ggmarshall
Copy link
Collaborator

For the ignore keyslist there are 2 cases, for raw we want to just remove the unprocesable keys while for higher tiers we want to remove both

@gipert
Copy link
Member Author

gipert commented Mar 16, 2025

ah ok. i don't have time to implement this now, do you want to do it? this can be merged

@ggmarshall
Copy link
Collaborator

sure I can do

@ggmarshall ggmarshall merged commit b1bbe44 into main Mar 16, 2025
11 checks passed
@ggmarshall ggmarshall deleted the raw branch March 16, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants