Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using deprecated method for getproperties #105

Merged
merged 1 commit into from
Mar 20, 2025
Merged

Conversation

fhagemann
Copy link
Contributor

Looks like we are using a deprecated method for TypesTable.getproperties in our package:
https://github.com/JuliaData/TypedTables.jl/blob/702cf7fdde8d6ac9822c8f43d695b50f6b183508/src/properties.jl#L87

I did not test whether this still works, but it's throwing deprecation warnings in tests.

@fhagemann fhagemann self-assigned this Mar 20, 2025
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 40.26%. Comparing base (12c1d59) to head (0852248).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
ext/LegendDataManagementLegendHDF5IOExt.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #105   +/-   ##
=======================================
  Coverage   40.26%   40.26%           
=======================================
  Files          27       27           
  Lines        2074     2074           
=======================================
  Hits          835      835           
  Misses       1239     1239           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fhagemann fhagemann requested a review from theHenks March 20, 2025 18:35
@theHenks theHenks merged commit d1c9503 into main Mar 20, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants