Skip to content

Fix fileName for android #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix fileName for android #7

wants to merge 1 commit into from

Conversation

mrgerych
Copy link

@mrgerych mrgerych commented Sep 5, 2018

I am discovered next issue:
keys is escaping and file name for key root:storage will be root%3Astorage.
The issue is that on android this file name stored as persist:pdfstorage
So fs.exists(pathForKey(key)) where pathForKey(key) = .../root%3Astorage return false for me

@leethree
Copy link
Owner

could you explain why the file name will become persist:pdfstorage?

@mrgerych
Copy link
Author

sure.
@leethree could you check next screens

screen shot 2018-09-13 at 12 04 14 pm

screen shot 2018-09-13 at 12 04 27 pm

beavis07
beavis07 approved these changes Oct 26, 2018
View reviewed changes
Copy link

@beavis07 beavis07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well played 👏 (Thanks - saved me some hours!)

@VladLazovskiy
Copy link

relevant
the key does not work on Android '@myapp:'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beavis07 beavis07 beavis07 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mrgerych @leethree @VladLazovskiy @beavis07